Merge pull request #29759 from backstage/freben/pinniped

remove backend-common from plugin-kubernetes-node

plugins/kubernetes-node/src/auth/PinnipedHelper.test.ts

@@ -35,14 +35,13 @@ import { HEADER_KUBERNETES_CLUSTER } from '@backstage/plugin-kubernetes-backend'
 import { JsonObject } from '@backstage/types';
 import { rest } from 'msw';
 import { setupServer } from 'msw/node';
-import { loggerToWinstonLogger } from '@backstage/backend-common';
 import { ExtendedHttpServer } from '@backstage/backend-defaults/rootHttpRouter';
 
 jest.setTimeout(60_000);
 
 describe('Pinniped - tokenCredentialRequest', () => {
   let app: ExtendedHttpServer;
-  const logger = loggerToWinstonLogger(mockServices.logger.mock());
+  const logger = mockServices.logger.mock();
   let httpsRequest: jest.SpyInstance;
   const worker = setupServer();
   registerMswTestHooks(worker);

plugins/kubernetes-node/src/auth/PinnipedHelper.ts

@@ -14,10 +14,10 @@
  * limitations under the License.
  */
 
+import { LoggerService } from '@backstage/backend-plugin-api';
 import { ClusterDetails } from '@backstage/plugin-kubernetes-node';
 import * as https from 'https';
 import fetch, { RequestInit } from 'node-fetch';
-import { Logger } from 'winston';
 
 /**
  *
@@ -50,7 +50,7 @@ export type PinnipedParameters = {
  * @public
  */
 export class PinnipedHelper {
-  constructor(private readonly logger: Logger) {}
+  constructor(private readonly logger: LoggerService) {}
 
   public async tokenCredentialRequest(
     clusterDetails: ClusterDetails,