From 10376e33c49889a439f7cbe99c6c4c4e3542331b Mon Sep 17 00:00:00 2001
From: hiba-aldalaty <hibaaldalaty@gmail.com>
Date: Mon, 22 Nov 2021 14:57:20 +0000
Subject: [PATCH] Improve use of conditional classes

Signed-off-by: hiba-aldalaty <hibaaldalaty@gmail.com>
---
 .../core-components/src/layout/Sidebar/Items.tsx     | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/packages/core-components/src/layout/Sidebar/Items.tsx b/packages/core-components/src/layout/Sidebar/Items.tsx
index f1b51e497f..8cdb8f75aa 100644
--- a/packages/core-components/src/layout/Sidebar/Items.tsx
+++ b/packages/core-components/src/layout/Sidebar/Items.tsx
@@ -221,7 +221,7 @@ const ItemWithSubmenu = ({
       color="secondary"
       variant="dot"
       overlap="circular"
-      className={isOpen ? undefined : classes.closedItemIcon}
+      className={isOpen ? '' : classes.closedItemIcon}
       invisible={!hasNotifications}
     >
       <Icon fontSize="small" />
@@ -251,7 +251,7 @@ const ItemWithSubmenu = ({
     >
       <div
         onMouseLeave={handleMouseLeave}
-        className={clsx(isHoveredOn ? classes.highlighted : undefined)}
+        className={clsx(isHoveredOn && classes.highlighted)}
       >
         <div
           onMouseEnter={handleMouseEnter}
@@ -259,9 +259,9 @@ const ItemWithSubmenu = ({
           className={clsx(
             classes.root,
             isOpen ? classes.open : classes.closed,
-            isActive ? classes.selected : undefined,
+            isActive && classes.selected,
             classes.highlightable,
-            isHoveredOn ? classes.highlighted : undefined,
+            isHoveredOn && classes.highlighted,
           )}
         >
           {isOpen ? openContent : closedContent}
@@ -372,7 +372,7 @@ export const SidebarItem = forwardRef<any, SidebarItemProps>((props, ref) => {
       variant="dot"
       overlap="circular"
       invisible={!hasNotifications}
-      className={clsx(isOpen ? undefined : classes.closedItemIcon)}
+      className={clsx({ [classes.closeItemIcon]: !isOpen })}
     >
       <Icon fontSize="small" />
     </Badge>
@@ -403,7 +403,7 @@ export const SidebarItem = forwardRef<any, SidebarItemProps>((props, ref) => {
       classes.root,
       isOpen ? classes.open : classes.closed,
       isButtonItem(props) && classes.buttonItem,
-      disableHighlight ? undefined : classes.highlightable,
+      { [classes.highlightable]: !disableHighlight },
     ),
   };