From 10276388979c6a8e804cc3647a1b445cfb143816 Mon Sep 17 00:00:00 2001 From: Andre Wanlin Date: Thu, 21 Mar 2024 11:34:27 +0100 Subject: [PATCH] Changes based on feedback Signed-off-by: Andre Wanlin --- ...rify-no-top-level-material-ui-4-imports.js | 22 ++++++++++--------- 1 file changed, 12 insertions(+), 10 deletions(-) diff --git a/scripts/verify-no-top-level-material-ui-4-imports.js b/scripts/verify-no-top-level-material-ui-4-imports.js index 9d2ac9aa71..a963b0c0b2 100644 --- a/scripts/verify-no-top-level-material-ui-4-imports.js +++ b/scripts/verify-no-top-level-material-ui-4-imports.js @@ -25,17 +25,19 @@ async function main() { for (const pkg of packages) { pkgRole = pkg.packageJson.backstage?.role; - if (pkgRole === 'frontend-plugin') { - const eslintrcPath = join(pkg.dir, '.eslintrc.js'); - const targetEslintrc = (await fs.readFile(eslintrcPath)).toString(); - if ( - targetEslintrc.includes( - "'@backstage/no-top-level-material-ui-4-imports': 'error'", - ) - ) { - continue; + if (pkgRole === 'frontend-plugin' || pkgRole === 'web-library') { + const depKeys = Object.keys(pkg.packageJson.dependencies); + if (depKeys.findIndex(d => d.includes('@material-ui')) !== -1) { + const eslintrcPath = join(pkg.dir, '.eslintrc.js'); + const targetEslintrc = (await fs.readFile(eslintrcPath)).toString(); + if ( + !targetEslintrc.includes( + "'@backstage/no-top-level-material-ui-4-imports': 'error'", + ) + ) { + console.log(pkg.packageJson.name); + } } - console.log(pkg.packageJson.name); } } }