From 0ffee55010c892c5928cab36fa80d5f382fa29cb Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Fredrik=20Adel=C3=B6w?= <freben@gmail.com>
Date: Tue, 28 Nov 2023 10:00:54 +0100
Subject: [PATCH] Toned down the warning message when git is not found
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Signed-off-by: Fredrik Adelöw <freben@gmail.com>
---
 .changeset/famous-peas-reflect.md      |  5 +++++
 packages/cli/src/lib/bundler/config.ts | 18 ++++++++++++------
 2 files changed, 17 insertions(+), 6 deletions(-)
 create mode 100644 .changeset/famous-peas-reflect.md

diff --git a/.changeset/famous-peas-reflect.md b/.changeset/famous-peas-reflect.md
new file mode 100644
index 0000000000..c8aed3c16b
--- /dev/null
+++ b/.changeset/famous-peas-reflect.md
@@ -0,0 +1,5 @@
+---
+'@backstage/cli': patch
+---
+
+Toned down the warning message when git is not found
diff --git a/packages/cli/src/lib/bundler/config.ts b/packages/cli/src/lib/bundler/config.ts
index 542cc83ce9..65c3853bc2 100644
--- a/packages/cli/src/lib/bundler/config.ts
+++ b/packages/cli/src/lib/bundler/config.ts
@@ -55,18 +55,24 @@ export function resolveBaseUrl(config: Config): URL {
 async function readBuildInfo() {
   const timestamp = Date.now();
 
-  let commit = 'unknown';
+  let commit: string | unknown;
   try {
     commit = await runPlain('git', 'rev-parse', 'HEAD');
   } catch (error) {
-    console.warn(`WARNING: Failed to read git commit, ${error}`);
+    // ignore, see below
   }
 
-  let gitVersion = 'unknown';
+  let gitVersion: string | unknown;
   try {
     gitVersion = await runPlain('git', 'describe', '--always');
   } catch (error) {
-    console.warn(`WARNING: Failed to describe git version, ${error}`);
+    // ignore, see below
+  }
+
+  if (commit === undefined || gitVersion === undefined) {
+    console.info(
+      'NOTE: Did not compute git version or commit hash, could not execute the git command line utility',
+    );
   }
 
   const { version: packageVersion } = await fs.readJson(
@@ -75,10 +81,10 @@ async function readBuildInfo() {
 
   return {
     cliVersion: version,
-    gitVersion,
+    gitVersion: gitVersion ?? 'unknown',
     packageVersion,
     timestamp,
-    commit,
+    commit: commit ?? 'unknown',
   };
 }