From 4ac08ce29043c20c8187ab095cf7676e8a3e98e2 Mon Sep 17 00:00:00 2001 From: Adam Harvey Date: Mon, 22 Feb 2021 21:50:23 -0500 Subject: [PATCH 01/12] Update display msgs when no entities exist Signed-off-by: Adam Harvey --- .../api-docs/src/components/ApisCards/ConsumedApisCard.tsx | 4 ++-- plugins/api-docs/src/components/ApisCards/HasApisCard.tsx | 4 ++-- .../api-docs/src/components/ApisCards/ProvidedApisCard.tsx | 4 ++-- .../components/ComponentsCards/ConsumingComponentsCard.tsx | 2 +- .../components/ComponentsCards/ProvidingComponentsCard.tsx | 2 +- 5 files changed, 8 insertions(+), 8 deletions(-) diff --git a/plugins/api-docs/src/components/ApisCards/ConsumedApisCard.tsx b/plugins/api-docs/src/components/ApisCards/ConsumedApisCard.tsx index adfa3cd34c..bd3944e600 100644 --- a/plugins/api-docs/src/components/ApisCards/ConsumedApisCard.tsx +++ b/plugins/api-docs/src/components/ApisCards/ConsumedApisCard.tsx @@ -72,9 +72,9 @@ export const ConsumedApisCard = ({ variant = 'gridItem' }: Props) => { variant={variant} emptyContent={
- No Component consumes this API.{' '} + This {entity.kind.toLowerCase()} does not consume any APIs.{' '} - Learn how to consume APIs. + (Learn how to change this.)
} diff --git a/plugins/api-docs/src/components/ApisCards/HasApisCard.tsx b/plugins/api-docs/src/components/ApisCards/HasApisCard.tsx index c3e636b1f1..be4b710d99 100644 --- a/plugins/api-docs/src/components/ApisCards/HasApisCard.tsx +++ b/plugins/api-docs/src/components/ApisCards/HasApisCard.tsx @@ -76,9 +76,9 @@ export const HasApisCard = ({ variant = 'gridItem' }: Props) => { variant={variant} emptyContent={
- No API is part of this system.{' '} + This {entity.kind.toLowerCase()} does not contain any APIs.{' '} - Learn how to add APIs. + (Learn how to add APIs.)
} diff --git a/plugins/api-docs/src/components/ApisCards/ProvidedApisCard.tsx b/plugins/api-docs/src/components/ApisCards/ProvidedApisCard.tsx index f02390b6d6..db045fb21f 100644 --- a/plugins/api-docs/src/components/ApisCards/ProvidedApisCard.tsx +++ b/plugins/api-docs/src/components/ApisCards/ProvidedApisCard.tsx @@ -72,9 +72,9 @@ export const ProvidedApisCard = ({ variant = 'gridItem' }: Props) => { variant={variant} emptyContent={
- No component provides this API.{' '} + This {entity.kind.toLowerCase()} does not provide it's own APIs.{' '} - Learn how to provide APIs. + (Learn how to change this.)
} diff --git a/plugins/api-docs/src/components/ComponentsCards/ConsumingComponentsCard.tsx b/plugins/api-docs/src/components/ComponentsCards/ConsumingComponentsCard.tsx index 7e4d97fece..9269679ec1 100644 --- a/plugins/api-docs/src/components/ComponentsCards/ConsumingComponentsCard.tsx +++ b/plugins/api-docs/src/components/ComponentsCards/ConsumingComponentsCard.tsx @@ -73,7 +73,7 @@ export const ConsumingComponentsCard = ({ variant = 'gridItem' }: Props) => {
No component consumes this API.{' '} - Learn how to consume APIs. + (Learn how to consume APIs.)
} diff --git a/plugins/api-docs/src/components/ComponentsCards/ProvidingComponentsCard.tsx b/plugins/api-docs/src/components/ComponentsCards/ProvidingComponentsCard.tsx index d755d8b5af..4e0d49428a 100644 --- a/plugins/api-docs/src/components/ComponentsCards/ProvidingComponentsCard.tsx +++ b/plugins/api-docs/src/components/ComponentsCards/ProvidingComponentsCard.tsx @@ -73,7 +73,7 @@ export const ProvidingComponentsCard = ({ variant = 'gridItem' }: Props) => {
No component provides this API.{' '} - Learn how to provide APIs. + (Learn how to provide APIs.)
} From 32a00397329566a35a319e999f17695df1b07e83 Mon Sep 17 00:00:00 2001 From: Adam Harvey Date: Mon, 22 Feb 2021 21:51:41 -0500 Subject: [PATCH 02/12] Add changeset Signed-off-by: Adam Harvey --- .changeset/empty-taxis-search.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .changeset/empty-taxis-search.md diff --git a/.changeset/empty-taxis-search.md b/.changeset/empty-taxis-search.md new file mode 100644 index 0000000000..f149a08c0d --- /dev/null +++ b/.changeset/empty-taxis-search.md @@ -0,0 +1,5 @@ +--- +'@backstage/plugin-api-docs': patch +--- + +Update messaging when no entities are in a table. From 994afea78b3c1a56bdce7a9a96e2fdab9480b63c Mon Sep 17 00:00:00 2001 From: Adam Harvey Date: Mon, 22 Feb 2021 21:56:01 -0500 Subject: [PATCH 03/12] Consistent learn more formatting Signed-off-by: Adam Harvey --- .../src/components/HasComponentsCard/HasComponentsCard.tsx | 2 +- .../components/HasSubcomponentsCard/HasSubcomponentsCard.tsx | 2 +- .../catalog/src/components/HasSystemsCard/HasSystemsCard.tsx | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/plugins/catalog/src/components/HasComponentsCard/HasComponentsCard.tsx b/plugins/catalog/src/components/HasComponentsCard/HasComponentsCard.tsx index eb8e96d9b3..53d42c1d82 100644 --- a/plugins/catalog/src/components/HasComponentsCard/HasComponentsCard.tsx +++ b/plugins/catalog/src/components/HasComponentsCard/HasComponentsCard.tsx @@ -76,7 +76,7 @@ export const HasComponentsCard = ({ variant = 'gridItem' }: Props) => {
No component is part of this system.{' '} - Learn how to add components. + (Learn how to add components.)
} diff --git a/plugins/catalog/src/components/HasSubcomponentsCard/HasSubcomponentsCard.tsx b/plugins/catalog/src/components/HasSubcomponentsCard/HasSubcomponentsCard.tsx index 778ec1dec5..5dd261ce3f 100644 --- a/plugins/catalog/src/components/HasSubcomponentsCard/HasSubcomponentsCard.tsx +++ b/plugins/catalog/src/components/HasSubcomponentsCard/HasSubcomponentsCard.tsx @@ -76,7 +76,7 @@ export const HasSubcomponentsCard = ({ variant = 'gridItem' }: Props) => {
No subcomponent is part of this component.{' '} - Learn how to add subcomponents. + (Learn how to add subcomponents.)
} diff --git a/plugins/catalog/src/components/HasSystemsCard/HasSystemsCard.tsx b/plugins/catalog/src/components/HasSystemsCard/HasSystemsCard.tsx index 5b18711d44..0ceab31a4d 100644 --- a/plugins/catalog/src/components/HasSystemsCard/HasSystemsCard.tsx +++ b/plugins/catalog/src/components/HasSystemsCard/HasSystemsCard.tsx @@ -73,7 +73,7 @@ export const HasSystemsCard = ({ variant = 'gridItem' }: Props) => {
No system is part of this domain.{' '} - Learn how to add systems. + (Learn how to add systems.)
} From f9fbca34d2236ff08d15665d154da1bc4ef7d031 Mon Sep 17 00:00:00 2001 From: Adam Harvey Date: Mon, 22 Feb 2021 22:51:13 -0500 Subject: [PATCH 04/12] Fix test checks Signed-off-by: Adam Harvey --- plugins/api-docs/src/components/ApisCards/HasApisCard.test.tsx | 2 +- .../api-docs/src/components/ApisCards/ProvidedApisCard.test.tsx | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/plugins/api-docs/src/components/ApisCards/HasApisCard.test.tsx b/plugins/api-docs/src/components/ApisCards/HasApisCard.test.tsx index 7b97f0867e..5db3ec2b48 100644 --- a/plugins/api-docs/src/components/ApisCards/HasApisCard.test.tsx +++ b/plugins/api-docs/src/components/ApisCards/HasApisCard.test.tsx @@ -74,7 +74,7 @@ describe('', () => { ); expect(getByText('APIs')).toBeInTheDocument(); - expect(getByText(/No API is part of this system/i)).toBeInTheDocument(); + expect(getByText(/does not contain any APIs/i)).toBeInTheDocument(); }); it('shows related APIs', async () => { diff --git a/plugins/api-docs/src/components/ApisCards/ProvidedApisCard.test.tsx b/plugins/api-docs/src/components/ApisCards/ProvidedApisCard.test.tsx index 0d49cc328d..f200ae5115 100644 --- a/plugins/api-docs/src/components/ApisCards/ProvidedApisCard.test.tsx +++ b/plugins/api-docs/src/components/ApisCards/ProvidedApisCard.test.tsx @@ -74,7 +74,7 @@ describe('', () => { ); expect(getByText(/Provided APIs/i)).toBeInTheDocument(); - expect(getByText(/No component provides this API/i)).toBeInTheDocument(); + expect(getByText(/does not provide it's own APIs/i)).toBeInTheDocument(); }); it('shows consumed APIs', async () => { From 7ac93ba76570e49cb8ed461a7feebc9280d05e6d Mon Sep 17 00:00:00 2001 From: Adam Harvey Date: Mon, 22 Feb 2021 22:52:55 -0500 Subject: [PATCH 05/12] Fix tests Signed-off-by: Adam Harvey --- .../api-docs/src/components/ApisCards/ConsumedApisCard.test.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/plugins/api-docs/src/components/ApisCards/ConsumedApisCard.test.tsx b/plugins/api-docs/src/components/ApisCards/ConsumedApisCard.test.tsx index 5d2978a198..b157e898ca 100644 --- a/plugins/api-docs/src/components/ApisCards/ConsumedApisCard.test.tsx +++ b/plugins/api-docs/src/components/ApisCards/ConsumedApisCard.test.tsx @@ -74,7 +74,7 @@ describe('', () => { ); expect(getByText(/Consumed APIs/i)).toBeInTheDocument(); - expect(getByText(/No Component consumes this API/i)).toBeInTheDocument(); + expect(getByText(/does not consume any APIs/i)).toBeInTheDocument(); }); it('shows consumed APIs', async () => { From a0049c043a38be6a3c37ff08159aa1fd257bb359 Mon Sep 17 00:00:00 2001 From: Adam Harvey Date: Mon, 22 Feb 2021 22:57:35 -0500 Subject: [PATCH 06/12] Fix its possessive Signed-off-by: Adam Harvey --- .../api-docs/src/components/ApisCards/ProvidedApisCard.test.tsx | 2 +- plugins/api-docs/src/components/ApisCards/ProvidedApisCard.tsx | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/plugins/api-docs/src/components/ApisCards/ProvidedApisCard.test.tsx b/plugins/api-docs/src/components/ApisCards/ProvidedApisCard.test.tsx index f200ae5115..37c2d87ee0 100644 --- a/plugins/api-docs/src/components/ApisCards/ProvidedApisCard.test.tsx +++ b/plugins/api-docs/src/components/ApisCards/ProvidedApisCard.test.tsx @@ -74,7 +74,7 @@ describe('', () => { ); expect(getByText(/Provided APIs/i)).toBeInTheDocument(); - expect(getByText(/does not provide it's own APIs/i)).toBeInTheDocument(); + expect(getByText(/does not provide its own APIs/i)).toBeInTheDocument(); }); it('shows consumed APIs', async () => { diff --git a/plugins/api-docs/src/components/ApisCards/ProvidedApisCard.tsx b/plugins/api-docs/src/components/ApisCards/ProvidedApisCard.tsx index db045fb21f..a80706d8e0 100644 --- a/plugins/api-docs/src/components/ApisCards/ProvidedApisCard.tsx +++ b/plugins/api-docs/src/components/ApisCards/ProvidedApisCard.tsx @@ -72,7 +72,7 @@ export const ProvidedApisCard = ({ variant = 'gridItem' }: Props) => { variant={variant} emptyContent={
- This {entity.kind.toLowerCase()} does not provide it's own APIs.{' '} + This {entity.kind.toLowerCase()} does not provide its own APIs.{' '} (Learn how to change this.) From 79bd6cd6098c2b8274003490da0219f286b65cd0 Mon Sep 17 00:00:00 2001 From: Adam Harvey Date: Tue, 23 Feb 2021 09:39:08 -0500 Subject: [PATCH 07/12] Update formatting Signed-off-by: Adam Harvey --- .../src/components/ApisCards/ConsumedApisCard.tsx | 15 ++++++++++----- .../src/components/ApisCards/HasApisCard.tsx | 15 ++++++++++----- .../ComponentsCards/ConsumingComponentsCard.tsx | 13 ++++++++----- .../ComponentsCards/ProvidingComponentsCard.tsx | 13 ++++++++----- 4 files changed, 36 insertions(+), 20 deletions(-) diff --git a/plugins/api-docs/src/components/ApisCards/ConsumedApisCard.tsx b/plugins/api-docs/src/components/ApisCards/ConsumedApisCard.tsx index bd3944e600..1af3f9803a 100644 --- a/plugins/api-docs/src/components/ApisCards/ConsumedApisCard.tsx +++ b/plugins/api-docs/src/components/ApisCards/ConsumedApisCard.tsx @@ -26,6 +26,7 @@ import { Progress, WarningPanel, } from '@backstage/core'; +import { Typography } from '@material-ui/core'; import { EntityTable, useEntity, @@ -71,11 +72,15 @@ export const ConsumedApisCard = ({ variant = 'gridItem' }: Props) => { title="Consumed APIs" variant={variant} emptyContent={ -
- This {entity.kind.toLowerCase()} does not consume any APIs.{' '} - - (Learn how to change this.) - +
+ + This {entity.kind.toLowerCase()} does not consume any APIs.{' '} + + + + Learn how to change this. + +
} columns={apiEntityColumns} diff --git a/plugins/api-docs/src/components/ApisCards/HasApisCard.tsx b/plugins/api-docs/src/components/ApisCards/HasApisCard.tsx index be4b710d99..3c0efc43be 100644 --- a/plugins/api-docs/src/components/ApisCards/HasApisCard.tsx +++ b/plugins/api-docs/src/components/ApisCards/HasApisCard.tsx @@ -23,6 +23,7 @@ import { TableColumn, WarningPanel, } from '@backstage/core'; +import { Typography } from '@material-ui/core'; import { EntityTable, useEntity, @@ -75,11 +76,15 @@ export const HasApisCard = ({ variant = 'gridItem' }: Props) => { title="APIs" variant={variant} emptyContent={ -
- This {entity.kind.toLowerCase()} does not contain any APIs.{' '} - - (Learn how to add APIs.) - +
+ + This {entity.kind.toLowerCase()} does not contain any APIs.{' '} + + + + Learn how to change this. + +
} columns={columns} diff --git a/plugins/api-docs/src/components/ComponentsCards/ConsumingComponentsCard.tsx b/plugins/api-docs/src/components/ComponentsCards/ConsumingComponentsCard.tsx index 9269679ec1..fa6a295e58 100644 --- a/plugins/api-docs/src/components/ComponentsCards/ConsumingComponentsCard.tsx +++ b/plugins/api-docs/src/components/ComponentsCards/ConsumingComponentsCard.tsx @@ -26,6 +26,7 @@ import { Progress, WarningPanel, } from '@backstage/core'; +import { Typography } from '@material-ui/core'; import { EntityTable, useEntity, @@ -70,11 +71,13 @@ export const ConsumingComponentsCard = ({ variant = 'gridItem' }: Props) => { title="Consumers" variant={variant} emptyContent={ -
- No component consumes this API.{' '} - - (Learn how to consume APIs.) - +
+ No component consumes this API. + + + Learn how to change this. + +
} columns={EntityTable.componentEntityColumns} diff --git a/plugins/api-docs/src/components/ComponentsCards/ProvidingComponentsCard.tsx b/plugins/api-docs/src/components/ComponentsCards/ProvidingComponentsCard.tsx index 4e0d49428a..ed4ecec619 100644 --- a/plugins/api-docs/src/components/ComponentsCards/ProvidingComponentsCard.tsx +++ b/plugins/api-docs/src/components/ComponentsCards/ProvidingComponentsCard.tsx @@ -26,6 +26,7 @@ import { Progress, WarningPanel, } from '@backstage/core'; +import { Typography } from '@material-ui/core'; import { EntityTable, useEntity, @@ -70,11 +71,13 @@ export const ProvidingComponentsCard = ({ variant = 'gridItem' }: Props) => { title="Providers" variant={variant} emptyContent={ -
- No component provides this API.{' '} - - (Learn how to provide APIs.) - +
+ No component provides this API. + + + Learn how to change this. + +
} columns={EntityTable.componentEntityColumns} From 440de45549aa4576e4f510c2ce81e5a3ec59a194 Mon Sep 17 00:00:00 2001 From: Adam Harvey Date: Tue, 23 Feb 2021 11:27:45 -0500 Subject: [PATCH 08/12] Add other affected component Signed-off-by: Adam Harvey --- .changeset/empty-taxis-search.md | 1 + 1 file changed, 1 insertion(+) diff --git a/.changeset/empty-taxis-search.md b/.changeset/empty-taxis-search.md index f149a08c0d..ad45f290d3 100644 --- a/.changeset/empty-taxis-search.md +++ b/.changeset/empty-taxis-search.md @@ -1,5 +1,6 @@ --- '@backstage/plugin-api-docs': patch +'@backstage/plugin-catalog': patch --- Update messaging when no entities are in a table. From 80af0fb577aa398c1623f67c81a530fecdac9d46 Mon Sep 17 00:00:00 2001 From: Adam Harvey Date: Tue, 23 Feb 2021 11:29:31 -0500 Subject: [PATCH 09/12] Update empty table formatting Signed-off-by: Adam Harvey --- .../src/components/ApisCards/ProvidedApisCard.tsx | 15 ++++++++++----- .../ComponentsCards/ProvidingComponentsCard.tsx | 2 +- .../HasComponentsCard/HasComponentsCard.tsx | 15 ++++++++++----- .../HasSubcomponentsCard/HasSubcomponentsCard.tsx | 15 ++++++++++----- .../components/HasSystemsCard/HasSystemsCard.tsx | 15 ++++++++++----- 5 files changed, 41 insertions(+), 21 deletions(-) diff --git a/plugins/api-docs/src/components/ApisCards/ProvidedApisCard.tsx b/plugins/api-docs/src/components/ApisCards/ProvidedApisCard.tsx index a80706d8e0..c6cca7a35f 100644 --- a/plugins/api-docs/src/components/ApisCards/ProvidedApisCard.tsx +++ b/plugins/api-docs/src/components/ApisCards/ProvidedApisCard.tsx @@ -26,6 +26,7 @@ import { Progress, WarningPanel, } from '@backstage/core'; +import { Typography } from '@material-ui/core'; import { EntityTable, useEntity, @@ -71,11 +72,15 @@ export const ProvidedApisCard = ({ variant = 'gridItem' }: Props) => { title="Provided APIs" variant={variant} emptyContent={ -
- This {entity.kind.toLowerCase()} does not provide its own APIs.{' '} - - (Learn how to change this.) - +
+ + This {entity.kind.toLowerCase()} does not provide its own APIs.{' '} + + + + Learn how to change this. + +
} columns={apiEntityColumns} diff --git a/plugins/api-docs/src/components/ComponentsCards/ProvidingComponentsCard.tsx b/plugins/api-docs/src/components/ComponentsCards/ProvidingComponentsCard.tsx index ed4ecec619..5d5158d9ae 100644 --- a/plugins/api-docs/src/components/ComponentsCards/ProvidingComponentsCard.tsx +++ b/plugins/api-docs/src/components/ComponentsCards/ProvidingComponentsCard.tsx @@ -72,7 +72,7 @@ export const ProvidingComponentsCard = ({ variant = 'gridItem' }: Props) => { variant={variant} emptyContent={
- No component provides this API. + No component provides this API. Learn how to change this. diff --git a/plugins/catalog/src/components/HasComponentsCard/HasComponentsCard.tsx b/plugins/catalog/src/components/HasComponentsCard/HasComponentsCard.tsx index 53d42c1d82..e993aa1a91 100644 --- a/plugins/catalog/src/components/HasComponentsCard/HasComponentsCard.tsx +++ b/plugins/catalog/src/components/HasComponentsCard/HasComponentsCard.tsx @@ -22,6 +22,7 @@ import { Progress, WarningPanel, } from '@backstage/core'; +import { Typography } from '@material-ui/core'; import { EntityTable, useEntity, @@ -73,11 +74,15 @@ export const HasComponentsCard = ({ variant = 'gridItem' }: Props) => { title="Components" variant={variant} emptyContent={ -
- No component is part of this system.{' '} - - (Learn how to add components.) - +
+ + No component is part of this system. + + + + Learn how to change this. + +
} columns={columns} diff --git a/plugins/catalog/src/components/HasSubcomponentsCard/HasSubcomponentsCard.tsx b/plugins/catalog/src/components/HasSubcomponentsCard/HasSubcomponentsCard.tsx index 5dd261ce3f..bcde4c576b 100644 --- a/plugins/catalog/src/components/HasSubcomponentsCard/HasSubcomponentsCard.tsx +++ b/plugins/catalog/src/components/HasSubcomponentsCard/HasSubcomponentsCard.tsx @@ -22,6 +22,7 @@ import { Progress, WarningPanel, } from '@backstage/core'; +import { Typography } from '@material-ui/core'; import { EntityTable, useEntity, @@ -73,11 +74,15 @@ export const HasSubcomponentsCard = ({ variant = 'gridItem' }: Props) => { title="Subcomponents" variant={variant} emptyContent={ -
- No subcomponent is part of this component.{' '} - - (Learn how to add subcomponents.) - +
+ + No subcomponent is part of this component. + + + + Learn how to change this. + +
} columns={columns} diff --git a/plugins/catalog/src/components/HasSystemsCard/HasSystemsCard.tsx b/plugins/catalog/src/components/HasSystemsCard/HasSystemsCard.tsx index 0ceab31a4d..0146bfc165 100644 --- a/plugins/catalog/src/components/HasSystemsCard/HasSystemsCard.tsx +++ b/plugins/catalog/src/components/HasSystemsCard/HasSystemsCard.tsx @@ -22,6 +22,7 @@ import { Progress, WarningPanel, } from '@backstage/core'; +import { Typography } from '@material-ui/core'; import { EntityTable, useEntity, @@ -70,11 +71,15 @@ export const HasSystemsCard = ({ variant = 'gridItem' }: Props) => { title="Systems" variant={variant} emptyContent={ -
- No system is part of this domain.{' '} - - (Learn how to add systems.) - +
+ + No system is part of this domain. + + + + Learn how to change this. + +
} columns={columns} From 5e09c0d6ba711618fb051d05ce5d028c5f42c88c Mon Sep 17 00:00:00 2001 From: Adam Harvey Date: Tue, 23 Feb 2021 11:37:44 -0500 Subject: [PATCH 10/12] Cleanup formatting Signed-off-by: Adam Harvey --- plugins/api-docs/src/components/ApisCards/ConsumedApisCard.tsx | 2 +- plugins/api-docs/src/components/ApisCards/HasApisCard.tsx | 2 +- plugins/api-docs/src/components/ApisCards/ProvidedApisCard.tsx | 2 +- .../src/components/ComponentsCards/ConsumingComponentsCard.tsx | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/plugins/api-docs/src/components/ApisCards/ConsumedApisCard.tsx b/plugins/api-docs/src/components/ApisCards/ConsumedApisCard.tsx index 1af3f9803a..d42dd7c7d5 100644 --- a/plugins/api-docs/src/components/ApisCards/ConsumedApisCard.tsx +++ b/plugins/api-docs/src/components/ApisCards/ConsumedApisCard.tsx @@ -74,7 +74,7 @@ export const ConsumedApisCard = ({ variant = 'gridItem' }: Props) => { emptyContent={
- This {entity.kind.toLowerCase()} does not consume any APIs.{' '} + This {entity.kind.toLowerCase()} does not consume any APIs. diff --git a/plugins/api-docs/src/components/ApisCards/HasApisCard.tsx b/plugins/api-docs/src/components/ApisCards/HasApisCard.tsx index 3c0efc43be..b3ae251cfb 100644 --- a/plugins/api-docs/src/components/ApisCards/HasApisCard.tsx +++ b/plugins/api-docs/src/components/ApisCards/HasApisCard.tsx @@ -78,7 +78,7 @@ export const HasApisCard = ({ variant = 'gridItem' }: Props) => { emptyContent={
- This {entity.kind.toLowerCase()} does not contain any APIs.{' '} + This {entity.kind.toLowerCase()} does not contain any APIs. diff --git a/plugins/api-docs/src/components/ApisCards/ProvidedApisCard.tsx b/plugins/api-docs/src/components/ApisCards/ProvidedApisCard.tsx index c6cca7a35f..19b0596dd6 100644 --- a/plugins/api-docs/src/components/ApisCards/ProvidedApisCard.tsx +++ b/plugins/api-docs/src/components/ApisCards/ProvidedApisCard.tsx @@ -74,7 +74,7 @@ export const ProvidedApisCard = ({ variant = 'gridItem' }: Props) => { emptyContent={
- This {entity.kind.toLowerCase()} does not provide its own APIs.{' '} + This {entity.kind.toLowerCase()} does not provide its own APIs. diff --git a/plugins/api-docs/src/components/ComponentsCards/ConsumingComponentsCard.tsx b/plugins/api-docs/src/components/ComponentsCards/ConsumingComponentsCard.tsx index fa6a295e58..d39a8876e8 100644 --- a/plugins/api-docs/src/components/ComponentsCards/ConsumingComponentsCard.tsx +++ b/plugins/api-docs/src/components/ComponentsCards/ConsumingComponentsCard.tsx @@ -72,7 +72,7 @@ export const ConsumingComponentsCard = ({ variant = 'gridItem' }: Props) => { variant={variant} emptyContent={
- No component consumes this API. + No component consumes this API. Learn how to change this. From 65e82b3b67810a6244a873970427f1128338304b Mon Sep 17 00:00:00 2001 From: Adam Harvey Date: Tue, 2 Mar 2021 13:08:49 -0500 Subject: [PATCH 11/12] Update wording and heading size Signed-off-by: Adam Harvey --- .../api-docs/src/components/ApisCards/ConsumedApisCard.tsx | 2 +- plugins/api-docs/src/components/ApisCards/HasApisCard.tsx | 2 +- .../src/components/ApisCards/ProvidedApisCard.test.tsx | 2 +- .../api-docs/src/components/ApisCards/ProvidedApisCard.tsx | 4 ++-- 4 files changed, 5 insertions(+), 5 deletions(-) diff --git a/plugins/api-docs/src/components/ApisCards/ConsumedApisCard.tsx b/plugins/api-docs/src/components/ApisCards/ConsumedApisCard.tsx index d42dd7c7d5..9c3203d532 100644 --- a/plugins/api-docs/src/components/ApisCards/ConsumedApisCard.tsx +++ b/plugins/api-docs/src/components/ApisCards/ConsumedApisCard.tsx @@ -73,7 +73,7 @@ export const ConsumedApisCard = ({ variant = 'gridItem' }: Props) => { variant={variant} emptyContent={
- + This {entity.kind.toLowerCase()} does not consume any APIs. diff --git a/plugins/api-docs/src/components/ApisCards/HasApisCard.tsx b/plugins/api-docs/src/components/ApisCards/HasApisCard.tsx index b3ae251cfb..beeb4d051e 100644 --- a/plugins/api-docs/src/components/ApisCards/HasApisCard.tsx +++ b/plugins/api-docs/src/components/ApisCards/HasApisCard.tsx @@ -77,7 +77,7 @@ export const HasApisCard = ({ variant = 'gridItem' }: Props) => { variant={variant} emptyContent={
- + This {entity.kind.toLowerCase()} does not contain any APIs. diff --git a/plugins/api-docs/src/components/ApisCards/ProvidedApisCard.test.tsx b/plugins/api-docs/src/components/ApisCards/ProvidedApisCard.test.tsx index 37c2d87ee0..bb9b2e60d9 100644 --- a/plugins/api-docs/src/components/ApisCards/ProvidedApisCard.test.tsx +++ b/plugins/api-docs/src/components/ApisCards/ProvidedApisCard.test.tsx @@ -74,7 +74,7 @@ describe('', () => { ); expect(getByText(/Provided APIs/i)).toBeInTheDocument(); - expect(getByText(/does not provide its own APIs/i)).toBeInTheDocument(); + expect(getByText(/does not provide any APIs/i)).toBeInTheDocument(); }); it('shows consumed APIs', async () => { diff --git a/plugins/api-docs/src/components/ApisCards/ProvidedApisCard.tsx b/plugins/api-docs/src/components/ApisCards/ProvidedApisCard.tsx index 19b0596dd6..2447054b89 100644 --- a/plugins/api-docs/src/components/ApisCards/ProvidedApisCard.tsx +++ b/plugins/api-docs/src/components/ApisCards/ProvidedApisCard.tsx @@ -73,8 +73,8 @@ export const ProvidedApisCard = ({ variant = 'gridItem' }: Props) => { variant={variant} emptyContent={
- - This {entity.kind.toLowerCase()} does not provide its own APIs. + + This {entity.kind.toLowerCase()} does not provide any APIs. From 6c311926cdd93a9c3136bae5481da1b4cc0063de Mon Sep 17 00:00:00 2001 From: Adam Harvey Date: Tue, 2 Mar 2021 13:11:33 -0500 Subject: [PATCH 12/12] Made headings consistent Signed-off-by: Adam Harvey --- .../components/ComponentsCards/ConsumingComponentsCard.tsx | 4 +++- .../components/ComponentsCards/ProvidingComponentsCard.tsx | 4 +++- .../src/components/HasComponentsCard/HasComponentsCard.tsx | 2 +- .../components/HasSubcomponentsCard/HasSubcomponentsCard.tsx | 2 +- .../catalog/src/components/HasSystemsCard/HasSystemsCard.tsx | 2 +- 5 files changed, 9 insertions(+), 5 deletions(-) diff --git a/plugins/api-docs/src/components/ComponentsCards/ConsumingComponentsCard.tsx b/plugins/api-docs/src/components/ComponentsCards/ConsumingComponentsCard.tsx index d39a8876e8..914d034237 100644 --- a/plugins/api-docs/src/components/ComponentsCards/ConsumingComponentsCard.tsx +++ b/plugins/api-docs/src/components/ComponentsCards/ConsumingComponentsCard.tsx @@ -72,7 +72,9 @@ export const ConsumingComponentsCard = ({ variant = 'gridItem' }: Props) => { variant={variant} emptyContent={
- No component consumes this API. + + No component consumes this API. + Learn how to change this. diff --git a/plugins/api-docs/src/components/ComponentsCards/ProvidingComponentsCard.tsx b/plugins/api-docs/src/components/ComponentsCards/ProvidingComponentsCard.tsx index 5d5158d9ae..7c87943a9b 100644 --- a/plugins/api-docs/src/components/ComponentsCards/ProvidingComponentsCard.tsx +++ b/plugins/api-docs/src/components/ComponentsCards/ProvidingComponentsCard.tsx @@ -72,7 +72,9 @@ export const ProvidingComponentsCard = ({ variant = 'gridItem' }: Props) => { variant={variant} emptyContent={
- No component provides this API. + + No component provides this API. + Learn how to change this. diff --git a/plugins/catalog/src/components/HasComponentsCard/HasComponentsCard.tsx b/plugins/catalog/src/components/HasComponentsCard/HasComponentsCard.tsx index e993aa1a91..b6eae81f30 100644 --- a/plugins/catalog/src/components/HasComponentsCard/HasComponentsCard.tsx +++ b/plugins/catalog/src/components/HasComponentsCard/HasComponentsCard.tsx @@ -75,7 +75,7 @@ export const HasComponentsCard = ({ variant = 'gridItem' }: Props) => { variant={variant} emptyContent={
- + No component is part of this system. diff --git a/plugins/catalog/src/components/HasSubcomponentsCard/HasSubcomponentsCard.tsx b/plugins/catalog/src/components/HasSubcomponentsCard/HasSubcomponentsCard.tsx index bcde4c576b..41244ba3d4 100644 --- a/plugins/catalog/src/components/HasSubcomponentsCard/HasSubcomponentsCard.tsx +++ b/plugins/catalog/src/components/HasSubcomponentsCard/HasSubcomponentsCard.tsx @@ -75,7 +75,7 @@ export const HasSubcomponentsCard = ({ variant = 'gridItem' }: Props) => { variant={variant} emptyContent={
- + No subcomponent is part of this component. diff --git a/plugins/catalog/src/components/HasSystemsCard/HasSystemsCard.tsx b/plugins/catalog/src/components/HasSystemsCard/HasSystemsCard.tsx index 0146bfc165..ea4de474de 100644 --- a/plugins/catalog/src/components/HasSystemsCard/HasSystemsCard.tsx +++ b/plugins/catalog/src/components/HasSystemsCard/HasSystemsCard.tsx @@ -72,7 +72,7 @@ export const HasSystemsCard = ({ variant = 'gridItem' }: Props) => { variant={variant} emptyContent={
- + No system is part of this domain.