From 0e4c640d0690c63a3752f3717f134e79608db715 Mon Sep 17 00:00:00 2001 From: Patrik Oldsberg Date: Sun, 29 Jan 2023 19:51:14 +0100 Subject: [PATCH] scaffolder-react: refert FormProps back to alpha Signed-off-by: Patrik Oldsberg --- .changeset/forty-bulldogs-build.md | 5 ----- plugins/scaffolder-react/api-report.md | 2 +- plugins/scaffolder-react/src/next/types.ts | 6 +++++- 3 files changed, 6 insertions(+), 7 deletions(-) delete mode 100644 .changeset/forty-bulldogs-build.md diff --git a/.changeset/forty-bulldogs-build.md b/.changeset/forty-bulldogs-build.md deleted file mode 100644 index aa7954a2c2..0000000000 --- a/.changeset/forty-bulldogs-build.md +++ /dev/null @@ -1,5 +0,0 @@ ---- -'@backstage/plugin-scaffolder-react': patch ---- - -The `FormProps` type is now correctly only available as an `/alpha` export. diff --git a/plugins/scaffolder-react/api-report.md b/plugins/scaffolder-react/api-report.md index 7068bbbd4f..deead4366c 100644 --- a/plugins/scaffolder-react/api-report.md +++ b/plugins/scaffolder-react/api-report.md @@ -121,7 +121,7 @@ export type FieldExtensionOptions< schema?: CustomFieldExtensionSchema; }; -// @alpha +// @public export type FormProps = Pick< FormProps_2, 'transformErrors' | 'noHtml5Validate' diff --git a/plugins/scaffolder-react/src/next/types.ts b/plugins/scaffolder-react/src/next/types.ts index f048b33ded..54a64a5323 100644 --- a/plugins/scaffolder-react/src/next/types.ts +++ b/plugins/scaffolder-react/src/next/types.ts @@ -16,10 +16,14 @@ import type { FormProps as SchemaFormProps } from '@rjsf/core-v5'; +// TODO(Rugvip): The FormProps type is actually supposed to be alpha, but since we want to +// refer to it from @backstage/plugin-scaffolder, it needs to be public for now. +// Once we support internal alpha re-exports this should be switched to an alpha export. + /** * Any `@rjsf/core` form properties that are publicly exposed to the `NextScaffolderpage` * - * @alpha + * @public */ export type FormProps = Pick< SchemaFormProps,