From 0e1941b8f8a43708138d3a32f0e10b481fbf2481 Mon Sep 17 00:00:00 2001 From: Aditya Kumar Date: Thu, 14 Mar 2024 08:21:03 +0530 Subject: [PATCH] Added Material UI 4 import rule to plugins/kubernetes Signed-off-by: Aditya Kumar --- .changeset/pink-zoos-own.md | 5 +++++ plugins/kubernetes/.eslintrc.js | 6 +++++- plugins/kubernetes/src/KubernetesContent.tsx | 3 ++- plugins/kubernetes/src/Router.tsx | 2 +- 4 files changed, 13 insertions(+), 3 deletions(-) create mode 100644 .changeset/pink-zoos-own.md diff --git a/.changeset/pink-zoos-own.md b/.changeset/pink-zoos-own.md new file mode 100644 index 0000000000..9a38855300 --- /dev/null +++ b/.changeset/pink-zoos-own.md @@ -0,0 +1,5 @@ +--- +'@backstage/plugin-kubernetes': patch +--- + +Added an optional ESLint rule - no-top-level-material-ui-4-imports -in kubernetes plugin which has an auto fix function to migrate the imports and used it to migrate the Material UI imports for plugins/kubernetes. diff --git a/plugins/kubernetes/.eslintrc.js b/plugins/kubernetes/.eslintrc.js index e2a53a6ad2..9d5b45a010 100644 --- a/plugins/kubernetes/.eslintrc.js +++ b/plugins/kubernetes/.eslintrc.js @@ -1 +1,5 @@ -module.exports = require('@backstage/cli/config/eslint-factory')(__dirname); +module.exports = require('@backstage/cli/config/eslint-factory')(__dirname, { + rules: { + '@backstage/no-top-level-material-ui-4-imports': 'error', + }, + }); \ No newline at end of file diff --git a/plugins/kubernetes/src/KubernetesContent.tsx b/plugins/kubernetes/src/KubernetesContent.tsx index ed00cb9a13..acd1ecc521 100644 --- a/plugins/kubernetes/src/KubernetesContent.tsx +++ b/plugins/kubernetes/src/KubernetesContent.tsx @@ -15,7 +15,8 @@ */ import React from 'react'; -import { Grid, Typography } from '@material-ui/core'; +import Grid from '@material-ui/core/Grid'; +import Typography from '@material-ui/core/Typography'; import { Entity } from '@backstage/catalog-model'; import { ErrorPanel, diff --git a/plugins/kubernetes/src/Router.tsx b/plugins/kubernetes/src/Router.tsx index 8266b1908e..db54d6c513 100644 --- a/plugins/kubernetes/src/Router.tsx +++ b/plugins/kubernetes/src/Router.tsx @@ -22,7 +22,7 @@ import { } from '@backstage/plugin-catalog-react'; import { Route, Routes } from 'react-router-dom'; import { KubernetesContent } from './KubernetesContent'; -import { Button } from '@material-ui/core'; +import Button from '@material-ui/core/Button'; const KUBERNETES_ANNOTATION = 'backstage.io/kubernetes-id'; const KUBERNETES_LABEL_SELECTOR_QUERY_ANNOTATION =