Propagate filter/entity errors properly to the table

plugins/catalog/src/components/CatalogPage/CatalogTabs.tsx

@@ -61,10 +61,12 @@ export const CatalogTabs = ({ tabs, onChange }: Props) => {
 
   const [currentTabIndex, setCurrentTabIndex] = useState<number>(0);
 
+  // Hold a reference to the callback
   const onChangeRef = useRef<OnChangeCallback>();
   useEffect(() => {
     onChangeRef.current = onChange;
   }, [onChange]);
+
   useEffect(() => {
     onChangeRef.current?.(tabs[currentTabIndex]);
   }, [tabs, currentTabIndex]);

plugins/catalog/src/filter/EntityFilterGroupsProvider.tsx

@@ -113,6 +113,8 @@ function useProvideEntityFilters(): FilterGroupsContext {
     register,
     unregister,
     setGroupSelectedFilters,
+    loading: !error && !entities,
+    error,
     filterGroupStates,
     matchingEntities,
   };

plugins/catalog/src/filter/context.ts

@@ -26,6 +26,8 @@ export type FilterGroupsContext = {
   ) => void;
   unregister: (filterGroupId: string) => void;
   setGroupSelectedFilters: (filterGroupId: string, filterIds: string[]) => void;
+  loading: boolean;
+  error?: Error;
   filterGroupStates: { [filterGroupId: string]: FilterGroupStates };
   matchingEntities: Entity[];
 };

plugins/catalog/src/filter/useFilteredEntities.ts

@@ -27,8 +27,8 @@ export function useFilteredEntities() {
   }
 
   return {
-    loading: false,
-    error: undefined,
+    loading: context.loading,
+    error: context.error,
     matchingEntities: context.matchingEntities,
   };
 }