From 10f26e88836e8b805316af68ef7ebbca24d769ca Mon Sep 17 00:00:00 2001 From: Jussi Hallila Date: Tue, 11 Jan 2022 12:09:17 +0100 Subject: [PATCH 1/2] Modify queries to perform better by filtering on subqueries as well Signed-off-by: Jussi Hallila --- .changeset/nervous-taxis-grin.md | 5 +++++ .../src/service/persistence/TechInsightsDatabase.ts | 2 ++ 2 files changed, 7 insertions(+) create mode 100644 .changeset/nervous-taxis-grin.md diff --git a/.changeset/nervous-taxis-grin.md b/.changeset/nervous-taxis-grin.md new file mode 100644 index 0000000000..5fb892baee --- /dev/null +++ b/.changeset/nervous-taxis-grin.md @@ -0,0 +1,5 @@ +--- +'@backstage/plugin-tech-insights-backend': patch +--- + +Modify queries to perform better by filtering on subqueries as well diff --git a/plugins/tech-insights-backend/src/service/persistence/TechInsightsDatabase.ts b/plugins/tech-insights-backend/src/service/persistence/TechInsightsDatabase.ts index 31a2997af5..7cbf5671c2 100644 --- a/plugins/tech-insights-backend/src/service/persistence/TechInsightsDatabase.ts +++ b/plugins/tech-insights-backend/src/service/persistence/TechInsightsDatabase.ts @@ -112,6 +112,8 @@ export class TechInsightsDatabase implements TechInsightsStore { this.db('facts') .max('timestamp') .column('id as subId') + .where({ entity: entityTriplet }) + .and.whereIn('id', ids) .groupBy('id') .as('subQ'), 'facts.id', From 5a14988da6999a31967425c53dc6c89e7ac58167 Mon Sep 17 00:00:00 2001 From: Jussi Hallila Date: Tue, 11 Jan 2022 12:12:54 +0100 Subject: [PATCH 2/2] Add dash to make vale happier. Signed-off-by: Jussi Hallila --- .changeset/nervous-taxis-grin.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.changeset/nervous-taxis-grin.md b/.changeset/nervous-taxis-grin.md index 5fb892baee..76deaa2d5c 100644 --- a/.changeset/nervous-taxis-grin.md +++ b/.changeset/nervous-taxis-grin.md @@ -2,4 +2,4 @@ '@backstage/plugin-tech-insights-backend': patch --- -Modify queries to perform better by filtering on subqueries as well +Modify queries to perform better by filtering on sub-queries as well