From 9329792dba1c706b546d9042e315c8467aae3b6a Mon Sep 17 00:00:00 2001 From: Adam Harvey Date: Mon, 1 May 2023 20:23:54 -0400 Subject: [PATCH 1/2] fix: Hide empty start time data for queued builds Signed-off-by: Adam Harvey --- .../BuildsPage/lib/CITable/CITable.tsx | 25 ++++++++++--------- 1 file changed, 13 insertions(+), 12 deletions(-) diff --git a/plugins/circleci/src/components/BuildsPage/lib/CITable/CITable.tsx b/plugins/circleci/src/components/BuildsPage/lib/CITable/CITable.tsx index a9d19bf6db..248275fb77 100644 --- a/plugins/circleci/src/components/BuildsPage/lib/CITable/CITable.tsx +++ b/plugins/circleci/src/components/BuildsPage/lib/CITable/CITable.tsx @@ -205,18 +205,19 @@ const generatedColumns: TableColumn[] = [ { title: 'Time', field: 'startTime', - render: (row: Partial) => ( - <> - - run {relativeTimeTo(row?.startTime)} - - - {row?.stopTime - ? `took ${durationHumanized(row?.startTime, row?.stopTime)}` - : ''} - - - ), + render: (row: Partial) => + row?.startTime ? ( + <> + + run {relativeTimeTo(row?.startTime)} + + + {row?.stopTime + ? `took ${durationHumanized(row?.startTime, row?.stopTime)}` + : ''} + + + ) : null, }, { title: 'Workflow', From 1c4958d905f9e155b53278fed4f518d012d30187 Mon Sep 17 00:00:00 2001 From: Adam Harvey Date: Mon, 1 May 2023 20:25:03 -0400 Subject: [PATCH 2/2] chore: Add changeset Signed-off-by: Adam Harvey --- .changeset/serious-hornets-remember.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .changeset/serious-hornets-remember.md diff --git a/.changeset/serious-hornets-remember.md b/.changeset/serious-hornets-remember.md new file mode 100644 index 0000000000..05221cd055 --- /dev/null +++ b/.changeset/serious-hornets-remember.md @@ -0,0 +1,5 @@ +--- +'@backstage/plugin-circleci': patch +--- + +Hide empty time field data for queued builds which haven't started yet