From a4c04c17ebdc0d7bfb8d98bcba68fbb6ef699671 Mon Sep 17 00:00:00 2001 From: Marko Simon Date: Fri, 23 Dec 2022 12:26:31 +0100 Subject: [PATCH 1/2] add nullchecks for uptimePercentage Signed-off-by: Marko Simon --- plugins/ilert/src/components/ServicesPage/ServicesTable.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/plugins/ilert/src/components/ServicesPage/ServicesTable.tsx b/plugins/ilert/src/components/ServicesPage/ServicesTable.tsx index 30a83e4cec..2597986031 100644 --- a/plugins/ilert/src/components/ServicesPage/ServicesTable.tsx +++ b/plugins/ilert/src/components/ServicesPage/ServicesTable.tsx @@ -86,7 +86,7 @@ export const ServicesTable = ({ cellStyle: smColumnStyle, headerStyle: smColumnStyle, render: rowData => ( - {rowData.uptime.uptimePercentage.p90} + {rowData.uptime?.uptimePercentage?.p90 || ''} ), }; const actionsColumn: TableColumn = { From b1279d396dcad51e780bc758b86bc3e8a5b4d489 Mon Sep 17 00:00:00 2001 From: Marko Simon Date: Fri, 23 Dec 2022 12:31:55 +0100 Subject: [PATCH 2/2] add changeset Signed-off-by: Marko Simon --- .changeset/strong-eyes-march.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .changeset/strong-eyes-march.md diff --git a/.changeset/strong-eyes-march.md b/.changeset/strong-eyes-march.md new file mode 100644 index 0000000000..4f3bbacfc8 --- /dev/null +++ b/.changeset/strong-eyes-march.md @@ -0,0 +1,5 @@ +--- +'@backstage/plugin-ilert': patch +--- + +fixed error on service page not showing if historical uptime was disabled on a service