From 0c1f57b6b6d047363e38449f49a8b53c455058cd Mon Sep 17 00:00:00 2001
From: Vincenzo Scamporlino <vincenzos@spotify.com>
Date: Fri, 11 Aug 2023 08:47:09 +0200
Subject: [PATCH] backend-app-api: add missing check for pluginMetadata service

Signed-off-by: Vincenzo Scamporlino <vincenzos@spotify.com>
---
 packages/backend-app-api/src/wiring/BackendInitializer.ts | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/packages/backend-app-api/src/wiring/BackendInitializer.ts b/packages/backend-app-api/src/wiring/BackendInitializer.ts
index ab4a059aac..2e90e6eb2c 100644
--- a/packages/backend-app-api/src/wiring/BackendInitializer.ts
+++ b/packages/backend-app-api/src/wiring/BackendInitializer.ts
@@ -107,6 +107,11 @@ export class BackendInitializer {
     }
 
     if (isServiceFactory(feature)) {
+      if (feature.service.id === coreServices.pluginMetadata.id) {
+        throw new Error(
+          `The ${coreServices.pluginMetadata.id} service cannot be overridden`,
+        );
+      }
       this.#serviceHolder.add(feature);
     } else if (isInternalBackendFeature(feature)) {
       if (feature.version !== 'v1') {