From 0a9deff5cb0178d60991fd139c90865b37525d2f Mon Sep 17 00:00:00 2001
From: benjdlambert <ben@blam.sh>
Date: Tue, 27 May 2025 15:12:16 +0200
Subject: [PATCH] chore: refactor the test

Signed-off-by: benjdlambert <ben@blam.sh>
---
 .../actions/DefaultActionsService.ts          | 28 ++++++++++---------
 1 file changed, 15 insertions(+), 13 deletions(-)

diff --git a/packages/backend-defaults/src/entrypoints/actions/DefaultActionsService.ts b/packages/backend-defaults/src/entrypoints/actions/DefaultActionsService.ts
index 4f11050646..2421482f4c 100644
--- a/packages/backend-defaults/src/entrypoints/actions/DefaultActionsService.ts
+++ b/packages/backend-defaults/src/entrypoints/actions/DefaultActionsService.ts
@@ -53,22 +53,24 @@ export class DefaultActionsService implements ActionsService {
 
     const remoteActionsList = await Promise.all(
       pluginSources.map(async source => {
-        const response = await this.makeRequest({
-          path: `/.backstage/actions/v1/actions`,
-          pluginId: source,
-          credentials,
-        });
+        try {
+          const response = await this.makeRequest({
+            path: `/.backstage/actions/v1/actions`,
+            pluginId: source,
+            credentials,
+          });
+          if (!response.ok) {
+            throw await ResponseError.fromResponse(response);
+          }
+          const { actions } = (await response.json()) as {
+            actions: ActionsServiceAction;
+          };
 
-        if (!response.ok) {
-          this.logger.warn(`Failed to fetch actions from ${source}`);
+          return actions;
+        } catch (error) {
+          this.logger.warn(`Failed to fetch actions from ${source}`, error);
           return [];
         }
-
-        const { actions } = (await response.json()) as {
-          actions: ActionsServiceAction;
-        };
-
-        return actions;
       }),
     );