From 2e036369d83bf46304a869522f3ced71a1441632 Mon Sep 17 00:00:00 2001
From: Andre Wanlin <67169551+awanlin@users.noreply.github.com>
Date: Sat, 17 Jun 2023 11:34:51 -0500
Subject: [PATCH] Use transient for info and sucess alerts

Signed-off-by: Andre Wanlin <67169551+awanlin@users.noreply.github.com>
---
 .changeset/six-dingos-end.md                             | 9 +++++++++
 plugins/catalog/src/components/AboutCard/AboutCard.tsx   | 6 +++++-
 .../src/components/BuildsPage/lib/CITable/CITable.tsx    | 1 +
 .../Cards/Group/GroupProfile/GroupProfileCard.tsx        | 6 +++++-
 .../EntityPlaylistDialog/EntityPlaylistDialog.test.tsx   | 1 +
 .../EntityPlaylistDialog/EntityPlaylistDialog.tsx        | 1 +
 plugins/shortcuts/src/AddShortcut.tsx                    | 1 +
 plugins/shortcuts/src/EditShortcut.tsx                   | 2 ++
 8 files changed, 25 insertions(+), 2 deletions(-)
 create mode 100644 .changeset/six-dingos-end.md

diff --git a/.changeset/six-dingos-end.md b/.changeset/six-dingos-end.md
new file mode 100644
index 0000000000..bac7cb4c1f
--- /dev/null
+++ b/.changeset/six-dingos-end.md
@@ -0,0 +1,9 @@
+---
+'@backstage/plugin-shortcuts': patch
+'@backstage/plugin-playlist': patch
+'@backstage/plugin-catalog': patch
+'@backstage/plugin-jenkins': patch
+'@backstage/plugin-org': patch
+---
+
+Updated `alertApi` usages with severity of `info` or `success` to use `display: transient`
diff --git a/plugins/catalog/src/components/AboutCard/AboutCard.tsx b/plugins/catalog/src/components/AboutCard/AboutCard.tsx
index a08a9be5a4..06cc020e51 100644
--- a/plugins/catalog/src/components/AboutCard/AboutCard.tsx
+++ b/plugins/catalog/src/components/AboutCard/AboutCard.tsx
@@ -172,7 +172,11 @@ export function AboutCard(props: AboutCardProps) {
   const refreshEntity = useCallback(async () => {
     try {
       await catalogApi.refreshEntity(stringifyEntityRef(entity));
-      alertApi.post({ message: 'Refresh scheduled', severity: 'info' });
+      alertApi.post({
+        message: 'Refresh scheduled',
+        severity: 'info',
+        display: 'transient',
+      });
     } catch (e) {
       errorApi.post(e);
     }
diff --git a/plugins/jenkins/src/components/BuildsPage/lib/CITable/CITable.tsx b/plugins/jenkins/src/components/BuildsPage/lib/CITable/CITable.tsx
index f2d108eaf7..f82ce2e7ec 100644
--- a/plugins/jenkins/src/components/BuildsPage/lib/CITable/CITable.tsx
+++ b/plugins/jenkins/src/components/BuildsPage/lib/CITable/CITable.tsx
@@ -191,6 +191,7 @@ const generatedColumns: TableColumn[] = [
               alertApi.post({
                 message: 'Jenkins re-build has successfully executed',
                 severity: 'success',
+                display: 'transient',
               });
             } catch (e) {
               alertApi.post({
diff --git a/plugins/org/src/components/Cards/Group/GroupProfile/GroupProfileCard.tsx b/plugins/org/src/components/Cards/Group/GroupProfile/GroupProfileCard.tsx
index e8f06e49b3..76527362ff 100644
--- a/plugins/org/src/components/Cards/Group/GroupProfile/GroupProfileCard.tsx
+++ b/plugins/org/src/components/Cards/Group/GroupProfile/GroupProfileCard.tsx
@@ -73,7 +73,11 @@ export const GroupProfileCard = (props: {
 
   const refreshEntity = useCallback(async () => {
     await catalogApi.refreshEntity(stringifyEntityRef(group));
-    alertApi.post({ message: 'Refresh scheduled', severity: 'info' });
+    alertApi.post({
+      message: 'Refresh scheduled',
+      severity: 'info',
+      display: 'transient',
+    });
   }, [catalogApi, alertApi, group]);
 
   if (!group) {
diff --git a/plugins/playlist/src/components/EntityPlaylistDialog/EntityPlaylistDialog.test.tsx b/plugins/playlist/src/components/EntityPlaylistDialog/EntityPlaylistDialog.test.tsx
index 1d9b298e19..828485bc3d 100644
--- a/plugins/playlist/src/components/EntityPlaylistDialog/EntityPlaylistDialog.test.tsx
+++ b/plugins/playlist/src/components/EntityPlaylistDialog/EntityPlaylistDialog.test.tsx
@@ -167,6 +167,7 @@ describe('EntityPlaylistDialog', () => {
       expect(alertApi.post).toHaveBeenCalledWith({
         message: 'Entity added to playlist-2',
         severity: 'success',
+        display: 'transient',
       });
     });
   });
diff --git a/plugins/playlist/src/components/EntityPlaylistDialog/EntityPlaylistDialog.tsx b/plugins/playlist/src/components/EntityPlaylistDialog/EntityPlaylistDialog.tsx
index 150ca6bc56..2c675d357f 100644
--- a/plugins/playlist/src/components/EntityPlaylistDialog/EntityPlaylistDialog.tsx
+++ b/plugins/playlist/src/components/EntityPlaylistDialog/EntityPlaylistDialog.tsx
@@ -159,6 +159,7 @@ export const EntityPlaylistDialog = (props: EntityPlaylistDialogProps) => {
         alertApi.post({
           message: `Entity added to ${playlist.name}`,
           severity: 'success',
+          display: 'transient',
         });
       } catch (e) {
         alertApi.post({
diff --git a/plugins/shortcuts/src/AddShortcut.tsx b/plugins/shortcuts/src/AddShortcut.tsx
index 6cca26d250..15850ab389 100644
--- a/plugins/shortcuts/src/AddShortcut.tsx
+++ b/plugins/shortcuts/src/AddShortcut.tsx
@@ -71,6 +71,7 @@ export const AddShortcut = ({
       alertApi.post({
         message: `Added shortcut '${title}' to your sidebar`,
         severity: 'success',
+        display: 'transient',
       });
     } catch (error) {
       alertApi.post({
diff --git a/plugins/shortcuts/src/EditShortcut.tsx b/plugins/shortcuts/src/EditShortcut.tsx
index a5f801604f..9f2ffe10be 100644
--- a/plugins/shortcuts/src/EditShortcut.tsx
+++ b/plugins/shortcuts/src/EditShortcut.tsx
@@ -74,6 +74,7 @@ export const EditShortcut = ({
       alertApi.post({
         message: `Updated shortcut '${title}'`,
         severity: 'success',
+        display: 'transient',
       });
     } catch (error) {
       alertApi.post({
@@ -91,6 +92,7 @@ export const EditShortcut = ({
       alertApi.post({
         message: `Removed shortcut '${shortcut.title}' from your sidebar`,
         severity: 'success',
+        display: 'transient',
       });
     } catch (error) {
       alertApi.post({