From 0a96d69434b2bf3f3b1c3009a7de083ce865e868 Mon Sep 17 00:00:00 2001 From: Rye Pasaporte Date: Fri, 21 Mar 2025 10:43:16 +0100 Subject: [PATCH] update function to contain only reading string rather than reading Date Signed-off-by: Rye Pasaporte --- .../src/components/FailedEntities.tsx | 2 +- .../src/plugin.test.ts | 14 ++++++++++---- 2 files changed, 11 insertions(+), 5 deletions(-) diff --git a/plugins/catalog-unprocessed-entities/src/components/FailedEntities.tsx b/plugins/catalog-unprocessed-entities/src/components/FailedEntities.tsx index 0f553986fc..7120728050 100644 --- a/plugins/catalog-unprocessed-entities/src/components/FailedEntities.tsx +++ b/plugins/catalog-unprocessed-entities/src/components/FailedEntities.tsx @@ -92,7 +92,7 @@ const RenderErrorContext = ({ * Converts input datetime which lacks timezone info into user's local time so that they can * easily understand the times. */ -export const convertTimeToLocalTimezone = (strDateTime: string | Date) => { +export const convertTimeToLocalTimezone = (strDateTime: string) => { const dateTime = DateTime.fromISO(strDateTime.toLocaleString(), { zone: DateTime.local().zoneName, }); diff --git a/plugins/catalog-unprocessed-entities/src/plugin.test.ts b/plugins/catalog-unprocessed-entities/src/plugin.test.ts index 7012f52dd9..8201dd97a8 100644 --- a/plugins/catalog-unprocessed-entities/src/plugin.test.ts +++ b/plugins/catalog-unprocessed-entities/src/plugin.test.ts @@ -29,9 +29,15 @@ describe('components/FailedEntities/convertTimeToLocalTimezone', () => { expect(localTime).toBe('2024-09-03 08:15:08 UTC'); }); - it('should correctly convert a UTC Date object to local time', () => { - const utcTime = new Date('2024-09-03T08:15:08.088Z'); - const localTime = convertTimeToLocalTimezone(utcTime); - expect(localTime).toBe('2024-09-03 08:15:08 UTC'); + it('should return "Invalid Date" for an invalid date string', () => { + const invalidTime = 'invalid-date-string'; + const localTime = convertTimeToLocalTimezone(invalidTime); + expect(localTime).toBe('Invalid DateTime'); + }); + + it('should handle empty string input', () => { + const emptyString = ''; + const localTime = convertTimeToLocalTimezone(emptyString); + expect(localTime).toBe('Invalid DateTime'); }); });