From 0a659c9b1db68c299ffbde9b788ae4b455eacce5 Mon Sep 17 00:00:00 2001 From: David Festal Date: Mon, 22 Jan 2024 16:10:05 +0100 Subject: [PATCH] Fix review comments: add a new constant for `no-cache` header value. Signed-off-by: David Festal --- plugins/app-backend/src/lib/headers.ts | 1 + plugins/app-backend/src/service/router.ts | 3 ++- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/plugins/app-backend/src/lib/headers.ts b/plugins/app-backend/src/lib/headers.ts index 1bee2bbb37..2483fdeee2 100644 --- a/plugins/app-backend/src/lib/headers.ts +++ b/plugins/app-backend/src/lib/headers.ts @@ -16,3 +16,4 @@ export const CACHE_CONTROL_NO_CACHE = 'no-store, max-age=0'; export const CACHE_CONTROL_MAX_CACHE = 'public, max-age=1209600'; // 14 days +export const CACHE_CONTROL_REVALIDATE_CACHE = 'no-cache'; // require revalidating cached responses before reuse them. diff --git a/plugins/app-backend/src/service/router.ts b/plugins/app-backend/src/service/router.ts index 6575b32612..5574892d37 100644 --- a/plugins/app-backend/src/service/router.ts +++ b/plugins/app-backend/src/service/router.ts @@ -35,6 +35,7 @@ import { import { CACHE_CONTROL_MAX_CACHE, CACHE_CONTROL_NO_CACHE, + CACHE_CONTROL_REVALIDATE_CACHE, } from '../lib/headers'; // express uses mime v1 while we only have types for mime v2 @@ -135,7 +136,7 @@ export async function createRouter( express.static(resolvePath(appDistDir, 'static'), { setHeaders: (res, path) => { if (path === injectedConfigPath) { - res.setHeader('Cache-Control', 'no-cache'); + res.setHeader('Cache-Control', CACHE_CONTROL_REVALIDATE_CACHE); } else { res.setHeader('Cache-Control', CACHE_CONTROL_MAX_CACHE); }