From 09b37063f2b1d05fbc87a87553cbb064b299287b Mon Sep 17 00:00:00 2001 From: Patrik Oldsberg Date: Mon, 7 Mar 2022 14:37:14 +0100 Subject: [PATCH] packages,plugins: migrate to new lint config Signed-off-by: Patrik Oldsberg --- packages/app-defaults/.eslintrc.js | 4 +- packages/app/.eslintrc.js | 5 +- packages/backend-common/.eslintrc.js | 4 +- packages/backend-tasks/.eslintrc.js | 4 +- packages/backend-test-utils/.eslintrc.js | 4 +- packages/backend/.eslintrc.js | 4 +- packages/catalog-client/.eslintrc.js | 4 +- packages/catalog-model/.eslintrc.js | 4 +- packages/cli-common/.eslintrc.js | 4 +- packages/cli/.eslintrc.js | 5 +- packages/codemods/.eslintrc.js | 5 +- packages/config-loader/.eslintrc.js | 4 +- packages/config/.eslintrc.js | 5 +- packages/core-app-api/.eslintrc.js | 6 +- packages/core-components/.eslintrc.js | 77 ++++++++++++++++--- packages/core-plugin-api/.eslintrc.js | 6 +- packages/create-app/.eslintrc.js | 5 +- packages/dev-utils/.eslintrc.js | 4 +- packages/e2e-test/.eslintrc.js | 5 +- packages/errors/.eslintrc.js | 4 +- packages/integration-react/.eslintrc.js | 4 +- packages/integration/.eslintrc.js | 4 +- packages/release-manifests/.eslintrc.js | 4 +- packages/search-common/.eslintrc.js | 4 +- .../techdocs-cli-embedded-app/.eslintrc.js | 4 +- packages/techdocs-cli/.eslintrc.js | 5 +- packages/techdocs-common/.eslintrc.js | 4 +- packages/test-utils/.eslintrc.js | 4 +- packages/theme/.eslintrc.js | 4 +- packages/types/.eslintrc.js | 4 +- packages/version-bridge/.eslintrc.js | 4 +- plugins/airbrake-backend/.eslintrc.js | 4 +- plugins/airbrake/.eslintrc.js | 4 +- plugins/allure/.eslintrc.js | 4 +- plugins/analytics-module-ga/.eslintrc.js | 4 +- plugins/apache-airflow/.eslintrc.js | 4 +- plugins/api-docs/.eslintrc.js | 4 +- plugins/app-backend/.eslintrc.js | 4 +- plugins/auth-backend/.eslintrc.js | 4 +- plugins/auth-node/.eslintrc.js | 4 +- plugins/azure-devops-backend/.eslintrc.js | 4 +- plugins/azure-devops-common/.eslintrc.js | 4 +- plugins/azure-devops/.eslintrc.js | 4 +- plugins/badges-backend/.eslintrc.js | 4 +- plugins/badges/.eslintrc.js | 4 +- plugins/bazaar-backend/.eslintrc.js | 4 +- plugins/bazaar/.eslintrc.js | 4 +- plugins/bitrise/.eslintrc.js | 4 +- .../catalog-backend-module-aws/.eslintrc.js | 4 +- .../catalog-backend-module-ldap/.eslintrc.js | 4 +- .../.eslintrc.js | 4 +- plugins/catalog-backend/.eslintrc.js | 4 +- plugins/catalog-common/.eslintrc.js | 4 +- plugins/catalog-graph/.eslintrc.js | 4 +- plugins/catalog-graphql/.eslintrc.js | 4 +- plugins/catalog-import/.eslintrc.js | 4 +- plugins/catalog-react/.eslintrc.js | 4 +- plugins/catalog/.eslintrc.js | 4 +- plugins/cicd-statistics/.eslintrc.js | 4 +- plugins/circleci/.eslintrc.js | 4 +- plugins/cloudbuild/.eslintrc.js | 4 +- plugins/code-climate/.eslintrc.js | 4 +- plugins/code-coverage-backend/.eslintrc.js | 4 +- plugins/code-coverage/.eslintrc.js | 4 +- plugins/config-schema/.eslintrc.js | 4 +- plugins/cost-insights/.eslintrc.js | 4 +- plugins/explore-react/.eslintrc.js | 4 +- plugins/explore/.eslintrc.js | 4 +- plugins/firehydrant/.eslintrc.js | 4 +- plugins/fossa/.eslintrc.js | 4 +- plugins/gcp-projects/.eslintrc.js | 4 +- plugins/git-release-manager/.eslintrc.js | 4 +- plugins/github-actions/.eslintrc.js | 4 +- plugins/github-deployments/.eslintrc.js | 4 +- plugins/gitops-profiles/.eslintrc.js | 4 +- plugins/gocd/.eslintrc.js | 4 +- plugins/graphiql/.eslintrc.js | 6 +- plugins/graphql-backend/.eslintrc.js | 4 +- plugins/home/.eslintrc.js | 4 +- plugins/ilert/.eslintrc.js | 5 +- plugins/jenkins-backend/.eslintrc.js | 4 +- plugins/jenkins-common/.eslintrc.js | 4 +- plugins/jenkins/.eslintrc.js | 4 +- plugins/kafka-backend/.eslintrc.js | 4 +- plugins/kafka/.eslintrc.js | 4 +- plugins/kubernetes-backend/.eslintrc.js | 4 +- plugins/kubernetes-common/.eslintrc.js | 4 +- plugins/kubernetes/.eslintrc.js | 4 +- plugins/lighthouse/.eslintrc.js | 4 +- plugins/newrelic-dashboard/.eslintrc.js | 4 +- plugins/newrelic/.eslintrc.js | 4 +- plugins/org/.eslintrc.js | 4 +- plugins/pagerduty/.eslintrc.js | 4 +- plugins/permission-backend/.eslintrc.js | 4 +- plugins/permission-common/.eslintrc.js | 4 +- plugins/permission-node/.eslintrc.js | 4 +- plugins/permission-react/.eslintrc.js | 4 +- plugins/proxy-backend/.eslintrc.js | 4 +- plugins/rollbar-backend/.eslintrc.js | 4 +- plugins/rollbar/.eslintrc.js | 4 +- .../.eslintrc.js | 4 +- .../.eslintrc.js | 4 +- .../.eslintrc.js | 4 +- plugins/scaffolder-backend/.eslintrc.js | 42 +++++++--- plugins/scaffolder-common/.eslintrc.js | 4 +- plugins/scaffolder/.eslintrc.js | 4 +- .../.eslintrc.js | 4 +- plugins/search-backend-module-pg/.eslintrc.js | 4 +- plugins/search-backend-node/.eslintrc.js | 4 +- plugins/search-backend/.eslintrc.js | 4 +- plugins/search-common/.eslintrc.js | 4 +- plugins/search/.eslintrc.js | 4 +- plugins/sentry/.eslintrc.js | 4 +- plugins/shortcuts/.eslintrc.js | 4 +- plugins/sonarqube/.eslintrc.js | 4 +- plugins/splunk-on-call/.eslintrc.js | 4 +- .../.eslintrc.js | 4 +- plugins/tech-insights-backend/.eslintrc.js | 5 +- plugins/tech-insights-common/.eslintrc.js | 4 +- plugins/tech-insights-node/.eslintrc.js | 4 +- plugins/tech-insights/.eslintrc.js | 4 +- plugins/tech-radar/.eslintrc.js | 4 +- plugins/techdocs-backend/.eslintrc.js | 5 +- plugins/techdocs-node/.eslintrc.js | 4 +- plugins/techdocs/.eslintrc.js | 4 +- plugins/todo-backend/.eslintrc.js | 4 +- plugins/todo/.eslintrc.js | 4 +- plugins/user-settings/.eslintrc.js | 4 +- plugins/xcmetrics/.eslintrc.js | 4 +- 129 files changed, 237 insertions(+), 406 deletions(-) diff --git a/packages/app-defaults/.eslintrc.js b/packages/app-defaults/.eslintrc.js index 13573efa9c..e2a53a6ad2 100644 --- a/packages/app-defaults/.eslintrc.js +++ b/packages/app-defaults/.eslintrc.js @@ -1,3 +1 @@ -module.exports = { - extends: [require.resolve('@backstage/cli/config/eslint')], -}; +module.exports = require('@backstage/cli/config/eslint-factory')(__dirname); diff --git a/packages/app/.eslintrc.js b/packages/app/.eslintrc.js index 930c98ee1b..7441f46811 100644 --- a/packages/app/.eslintrc.js +++ b/packages/app/.eslintrc.js @@ -1,5 +1,4 @@ -module.exports = { - extends: [require.resolve('@backstage/cli/config/eslint')], +module.exports = require('@backstage/cli/config/eslint-factory')(__dirname, { overrides: [ { files: ['**/*.ts?(x)'], @@ -8,4 +7,4 @@ module.exports = { }, }, ], -}; +}); diff --git a/packages/backend-common/.eslintrc.js b/packages/backend-common/.eslintrc.js index 16a033dbc6..e2a53a6ad2 100644 --- a/packages/backend-common/.eslintrc.js +++ b/packages/backend-common/.eslintrc.js @@ -1,3 +1 @@ -module.exports = { - extends: [require.resolve('@backstage/cli/config/eslint.backend')], -}; +module.exports = require('@backstage/cli/config/eslint-factory')(__dirname); diff --git a/packages/backend-tasks/.eslintrc.js b/packages/backend-tasks/.eslintrc.js index 16a033dbc6..e2a53a6ad2 100644 --- a/packages/backend-tasks/.eslintrc.js +++ b/packages/backend-tasks/.eslintrc.js @@ -1,3 +1 @@ -module.exports = { - extends: [require.resolve('@backstage/cli/config/eslint.backend')], -}; +module.exports = require('@backstage/cli/config/eslint-factory')(__dirname); diff --git a/packages/backend-test-utils/.eslintrc.js b/packages/backend-test-utils/.eslintrc.js index 16a033dbc6..e2a53a6ad2 100644 --- a/packages/backend-test-utils/.eslintrc.js +++ b/packages/backend-test-utils/.eslintrc.js @@ -1,3 +1 @@ -module.exports = { - extends: [require.resolve('@backstage/cli/config/eslint.backend')], -}; +module.exports = require('@backstage/cli/config/eslint-factory')(__dirname); diff --git a/packages/backend/.eslintrc.js b/packages/backend/.eslintrc.js index 16a033dbc6..e2a53a6ad2 100644 --- a/packages/backend/.eslintrc.js +++ b/packages/backend/.eslintrc.js @@ -1,3 +1 @@ -module.exports = { - extends: [require.resolve('@backstage/cli/config/eslint.backend')], -}; +module.exports = require('@backstage/cli/config/eslint-factory')(__dirname); diff --git a/packages/catalog-client/.eslintrc.js b/packages/catalog-client/.eslintrc.js index 13573efa9c..e2a53a6ad2 100644 --- a/packages/catalog-client/.eslintrc.js +++ b/packages/catalog-client/.eslintrc.js @@ -1,3 +1 @@ -module.exports = { - extends: [require.resolve('@backstage/cli/config/eslint')], -}; +module.exports = require('@backstage/cli/config/eslint-factory')(__dirname); diff --git a/packages/catalog-model/.eslintrc.js b/packages/catalog-model/.eslintrc.js index 13573efa9c..e2a53a6ad2 100644 --- a/packages/catalog-model/.eslintrc.js +++ b/packages/catalog-model/.eslintrc.js @@ -1,3 +1 @@ -module.exports = { - extends: [require.resolve('@backstage/cli/config/eslint')], -}; +module.exports = require('@backstage/cli/config/eslint-factory')(__dirname); diff --git a/packages/cli-common/.eslintrc.js b/packages/cli-common/.eslintrc.js index 16a033dbc6..e2a53a6ad2 100644 --- a/packages/cli-common/.eslintrc.js +++ b/packages/cli-common/.eslintrc.js @@ -1,3 +1 @@ -module.exports = { - extends: [require.resolve('@backstage/cli/config/eslint.backend')], -}; +module.exports = require('@backstage/cli/config/eslint-factory')(__dirname); diff --git a/packages/cli/.eslintrc.js b/packages/cli/.eslintrc.js index 69bec6cd2a..e9ea2f5bfb 100644 --- a/packages/cli/.eslintrc.js +++ b/packages/cli/.eslintrc.js @@ -1,7 +1,6 @@ -module.exports = { - extends: [require.resolve('@backstage/cli/config/eslint.backend')], +module.exports = require('@backstage/cli/config/eslint-factory')(__dirname, { ignorePatterns: ['templates/**'], rules: { 'no-console': 0, }, -}; +}); diff --git a/packages/codemods/.eslintrc.js b/packages/codemods/.eslintrc.js index 7c8a092081..f9fb2e27c9 100644 --- a/packages/codemods/.eslintrc.js +++ b/packages/codemods/.eslintrc.js @@ -1,5 +1,4 @@ -module.exports = { - extends: [require.resolve('@backstage/cli/config/eslint.backend')], +module.exports = require('@backstage/cli/config/eslint-factory')(__dirname, { rules: { 'no-console': 0, 'import/no-extraneous-dependencies': [ @@ -12,4 +11,4 @@ module.exports = { }, ], }, -}; +}); diff --git a/packages/config-loader/.eslintrc.js b/packages/config-loader/.eslintrc.js index 16a033dbc6..e2a53a6ad2 100644 --- a/packages/config-loader/.eslintrc.js +++ b/packages/config-loader/.eslintrc.js @@ -1,3 +1 @@ -module.exports = { - extends: [require.resolve('@backstage/cli/config/eslint.backend')], -}; +module.exports = require('@backstage/cli/config/eslint-factory')(__dirname); diff --git a/packages/config/.eslintrc.js b/packages/config/.eslintrc.js index 54e1fff915..e358722664 100644 --- a/packages/config/.eslintrc.js +++ b/packages/config/.eslintrc.js @@ -1,6 +1,5 @@ -module.exports = { - extends: [require.resolve('@backstage/cli/config/eslint')], +module.exports = require('@backstage/cli/config/eslint-factory')(__dirname, { rules: { 'jest/expect-expect': 0, }, -}; +}); diff --git a/packages/core-app-api/.eslintrc.js b/packages/core-app-api/.eslintrc.js index d592a653c8..3c32e018c8 100644 --- a/packages/core-app-api/.eslintrc.js +++ b/packages/core-app-api/.eslintrc.js @@ -1,8 +1,6 @@ -module.exports = { - extends: [require.resolve('@backstage/cli/config/eslint')], +module.exports = require('@backstage/cli/config/eslint-factory')(__dirname, { rules: { - // TODO: add prop types to JS and remove 'react/prop-types': 0, 'jest/expect-expect': 0, }, -}; +}); diff --git a/packages/core-components/.eslintrc.js b/packages/core-components/.eslintrc.js index 65a93d3660..65bfa69f59 100644 --- a/packages/core-components/.eslintrc.js +++ b/packages/core-components/.eslintrc.js @@ -1,25 +1,82 @@ -const base = require('@backstage/cli/config/eslint'); -const [, baseRestrictedImports] = base.rules['no-restricted-imports']; - -module.exports = { - extends: [require.resolve('@backstage/cli/config/eslint')], +module.exports = require('@backstage/cli/config/eslint-factory')(__dirname, { rules: { - // TODO: add prop types to JS and remove 'react/prop-types': 0, 'jest/expect-expect': 0, 'no-restricted-imports': [ 2, { - ...baseRestrictedImports, paths: [ { - // Importing the entire MUI icons packages kills build performance as the list of icons is huge. name: '@material-ui/core', message: "Please import '@material-ui/core/...' instead.", }, - ...baseRestrictedImports.paths, + { + name: '@material-ui/icons', + message: "Please import '@material-ui/icons/' instead.", + }, + { + name: '@material-ui/icons/', + message: "Please import '@material-ui/icons/' instead.", + }, + '_http_agent', + '_http_client', + '_http_common', + '_http_incoming', + '_http_outgoing', + '_http_server', + '_stream_duplex', + '_stream_passthrough', + '_stream_readable', + '_stream_transform', + '_stream_wrap', + '_stream_writable', + '_tls_common', + '_tls_wrap', + 'assert', + 'async_hooks', + 'buffer', + 'child_process', + 'cluster', + 'console', + 'constants', + 'crypto', + 'dgram', + 'diagnostics_channel', + 'dns', + 'domain', + 'events', + 'fs', + 'fs/promises', + 'http', + 'http2', + 'https', + 'inspector', + 'module', + 'net', + 'os', + 'path', + 'perf_hooks', + 'process', + 'punycode', + 'querystring', + 'readline', + 'repl', + 'stream', + 'string_decoder', + 'sys', + 'timers', + 'tls', + 'trace_events', + 'tty', + 'url', + 'util', + 'v8', + 'vm', + 'worker_threads', + 'zlib', ], + patterns: ['**/../../**/*/src/**', '**/../../**/*/src'], }, ], }, -}; +}); diff --git a/packages/core-plugin-api/.eslintrc.js b/packages/core-plugin-api/.eslintrc.js index d592a653c8..3c32e018c8 100644 --- a/packages/core-plugin-api/.eslintrc.js +++ b/packages/core-plugin-api/.eslintrc.js @@ -1,8 +1,6 @@ -module.exports = { - extends: [require.resolve('@backstage/cli/config/eslint')], +module.exports = require('@backstage/cli/config/eslint-factory')(__dirname, { rules: { - // TODO: add prop types to JS and remove 'react/prop-types': 0, 'jest/expect-expect': 0, }, -}; +}); diff --git a/packages/create-app/.eslintrc.js b/packages/create-app/.eslintrc.js index 69bec6cd2a..e9ea2f5bfb 100644 --- a/packages/create-app/.eslintrc.js +++ b/packages/create-app/.eslintrc.js @@ -1,7 +1,6 @@ -module.exports = { - extends: [require.resolve('@backstage/cli/config/eslint.backend')], +module.exports = require('@backstage/cli/config/eslint-factory')(__dirname, { ignorePatterns: ['templates/**'], rules: { 'no-console': 0, }, -}; +}); diff --git a/packages/dev-utils/.eslintrc.js b/packages/dev-utils/.eslintrc.js index 13573efa9c..e2a53a6ad2 100644 --- a/packages/dev-utils/.eslintrc.js +++ b/packages/dev-utils/.eslintrc.js @@ -1,3 +1 @@ -module.exports = { - extends: [require.resolve('@backstage/cli/config/eslint')], -}; +module.exports = require('@backstage/cli/config/eslint-factory')(__dirname); diff --git a/packages/e2e-test/.eslintrc.js b/packages/e2e-test/.eslintrc.js index 7c8a092081..f9fb2e27c9 100644 --- a/packages/e2e-test/.eslintrc.js +++ b/packages/e2e-test/.eslintrc.js @@ -1,5 +1,4 @@ -module.exports = { - extends: [require.resolve('@backstage/cli/config/eslint.backend')], +module.exports = require('@backstage/cli/config/eslint-factory')(__dirname, { rules: { 'no-console': 0, 'import/no-extraneous-dependencies': [ @@ -12,4 +11,4 @@ module.exports = { }, ], }, -}; +}); diff --git a/packages/errors/.eslintrc.js b/packages/errors/.eslintrc.js index 13573efa9c..e2a53a6ad2 100644 --- a/packages/errors/.eslintrc.js +++ b/packages/errors/.eslintrc.js @@ -1,3 +1 @@ -module.exports = { - extends: [require.resolve('@backstage/cli/config/eslint')], -}; +module.exports = require('@backstage/cli/config/eslint-factory')(__dirname); diff --git a/packages/integration-react/.eslintrc.js b/packages/integration-react/.eslintrc.js index 13573efa9c..e2a53a6ad2 100644 --- a/packages/integration-react/.eslintrc.js +++ b/packages/integration-react/.eslintrc.js @@ -1,3 +1 @@ -module.exports = { - extends: [require.resolve('@backstage/cli/config/eslint')], -}; +module.exports = require('@backstage/cli/config/eslint-factory')(__dirname); diff --git a/packages/integration/.eslintrc.js b/packages/integration/.eslintrc.js index 13573efa9c..e2a53a6ad2 100644 --- a/packages/integration/.eslintrc.js +++ b/packages/integration/.eslintrc.js @@ -1,3 +1 @@ -module.exports = { - extends: [require.resolve('@backstage/cli/config/eslint')], -}; +module.exports = require('@backstage/cli/config/eslint-factory')(__dirname); diff --git a/packages/release-manifests/.eslintrc.js b/packages/release-manifests/.eslintrc.js index 16a033dbc6..e2a53a6ad2 100644 --- a/packages/release-manifests/.eslintrc.js +++ b/packages/release-manifests/.eslintrc.js @@ -1,3 +1 @@ -module.exports = { - extends: [require.resolve('@backstage/cli/config/eslint.backend')], -}; +module.exports = require('@backstage/cli/config/eslint-factory')(__dirname); diff --git a/packages/search-common/.eslintrc.js b/packages/search-common/.eslintrc.js index 16a033dbc6..e2a53a6ad2 100644 --- a/packages/search-common/.eslintrc.js +++ b/packages/search-common/.eslintrc.js @@ -1,3 +1 @@ -module.exports = { - extends: [require.resolve('@backstage/cli/config/eslint.backend')], -}; +module.exports = require('@backstage/cli/config/eslint-factory')(__dirname); diff --git a/packages/techdocs-cli-embedded-app/.eslintrc.js b/packages/techdocs-cli-embedded-app/.eslintrc.js index 13573efa9c..e2a53a6ad2 100644 --- a/packages/techdocs-cli-embedded-app/.eslintrc.js +++ b/packages/techdocs-cli-embedded-app/.eslintrc.js @@ -1,3 +1 @@ -module.exports = { - extends: [require.resolve('@backstage/cli/config/eslint')], -}; +module.exports = require('@backstage/cli/config/eslint-factory')(__dirname); diff --git a/packages/techdocs-cli/.eslintrc.js b/packages/techdocs-cli/.eslintrc.js index 884f559c0f..8b5adc6794 100644 --- a/packages/techdocs-cli/.eslintrc.js +++ b/packages/techdocs-cli/.eslintrc.js @@ -1,5 +1,4 @@ -module.exports = { - extends: [require.resolve('@backstage/cli/config/eslint')], +module.exports = require('@backstage/cli/config/eslint-factory')(__dirname, { overrides: [ { files: ['**/*.ts?(x)'], @@ -8,4 +7,4 @@ module.exports = { }, }, ], -}; +}); diff --git a/packages/techdocs-common/.eslintrc.js b/packages/techdocs-common/.eslintrc.js index 16a033dbc6..e2a53a6ad2 100644 --- a/packages/techdocs-common/.eslintrc.js +++ b/packages/techdocs-common/.eslintrc.js @@ -1,3 +1 @@ -module.exports = { - extends: [require.resolve('@backstage/cli/config/eslint.backend')], -}; +module.exports = require('@backstage/cli/config/eslint-factory')(__dirname); diff --git a/packages/test-utils/.eslintrc.js b/packages/test-utils/.eslintrc.js index 13573efa9c..e2a53a6ad2 100644 --- a/packages/test-utils/.eslintrc.js +++ b/packages/test-utils/.eslintrc.js @@ -1,3 +1 @@ -module.exports = { - extends: [require.resolve('@backstage/cli/config/eslint')], -}; +module.exports = require('@backstage/cli/config/eslint-factory')(__dirname); diff --git a/packages/theme/.eslintrc.js b/packages/theme/.eslintrc.js index 13573efa9c..e2a53a6ad2 100644 --- a/packages/theme/.eslintrc.js +++ b/packages/theme/.eslintrc.js @@ -1,3 +1 @@ -module.exports = { - extends: [require.resolve('@backstage/cli/config/eslint')], -}; +module.exports = require('@backstage/cli/config/eslint-factory')(__dirname); diff --git a/packages/types/.eslintrc.js b/packages/types/.eslintrc.js index 13573efa9c..e2a53a6ad2 100644 --- a/packages/types/.eslintrc.js +++ b/packages/types/.eslintrc.js @@ -1,3 +1 @@ -module.exports = { - extends: [require.resolve('@backstage/cli/config/eslint')], -}; +module.exports = require('@backstage/cli/config/eslint-factory')(__dirname); diff --git a/packages/version-bridge/.eslintrc.js b/packages/version-bridge/.eslintrc.js index 13573efa9c..e2a53a6ad2 100644 --- a/packages/version-bridge/.eslintrc.js +++ b/packages/version-bridge/.eslintrc.js @@ -1,3 +1 @@ -module.exports = { - extends: [require.resolve('@backstage/cli/config/eslint')], -}; +module.exports = require('@backstage/cli/config/eslint-factory')(__dirname); diff --git a/plugins/airbrake-backend/.eslintrc.js b/plugins/airbrake-backend/.eslintrc.js index 16a033dbc6..e2a53a6ad2 100644 --- a/plugins/airbrake-backend/.eslintrc.js +++ b/plugins/airbrake-backend/.eslintrc.js @@ -1,3 +1 @@ -module.exports = { - extends: [require.resolve('@backstage/cli/config/eslint.backend')], -}; +module.exports = require('@backstage/cli/config/eslint-factory')(__dirname); diff --git a/plugins/airbrake/.eslintrc.js b/plugins/airbrake/.eslintrc.js index 13573efa9c..e2a53a6ad2 100644 --- a/plugins/airbrake/.eslintrc.js +++ b/plugins/airbrake/.eslintrc.js @@ -1,3 +1 @@ -module.exports = { - extends: [require.resolve('@backstage/cli/config/eslint')], -}; +module.exports = require('@backstage/cli/config/eslint-factory')(__dirname); diff --git a/plugins/allure/.eslintrc.js b/plugins/allure/.eslintrc.js index 13573efa9c..e2a53a6ad2 100644 --- a/plugins/allure/.eslintrc.js +++ b/plugins/allure/.eslintrc.js @@ -1,3 +1 @@ -module.exports = { - extends: [require.resolve('@backstage/cli/config/eslint')], -}; +module.exports = require('@backstage/cli/config/eslint-factory')(__dirname); diff --git a/plugins/analytics-module-ga/.eslintrc.js b/plugins/analytics-module-ga/.eslintrc.js index 13573efa9c..e2a53a6ad2 100644 --- a/plugins/analytics-module-ga/.eslintrc.js +++ b/plugins/analytics-module-ga/.eslintrc.js @@ -1,3 +1 @@ -module.exports = { - extends: [require.resolve('@backstage/cli/config/eslint')], -}; +module.exports = require('@backstage/cli/config/eslint-factory')(__dirname); diff --git a/plugins/apache-airflow/.eslintrc.js b/plugins/apache-airflow/.eslintrc.js index 13573efa9c..e2a53a6ad2 100644 --- a/plugins/apache-airflow/.eslintrc.js +++ b/plugins/apache-airflow/.eslintrc.js @@ -1,3 +1 @@ -module.exports = { - extends: [require.resolve('@backstage/cli/config/eslint')], -}; +module.exports = require('@backstage/cli/config/eslint-factory')(__dirname); diff --git a/plugins/api-docs/.eslintrc.js b/plugins/api-docs/.eslintrc.js index 13573efa9c..e2a53a6ad2 100644 --- a/plugins/api-docs/.eslintrc.js +++ b/plugins/api-docs/.eslintrc.js @@ -1,3 +1 @@ -module.exports = { - extends: [require.resolve('@backstage/cli/config/eslint')], -}; +module.exports = require('@backstage/cli/config/eslint-factory')(__dirname); diff --git a/plugins/app-backend/.eslintrc.js b/plugins/app-backend/.eslintrc.js index 16a033dbc6..e2a53a6ad2 100644 --- a/plugins/app-backend/.eslintrc.js +++ b/plugins/app-backend/.eslintrc.js @@ -1,3 +1 @@ -module.exports = { - extends: [require.resolve('@backstage/cli/config/eslint.backend')], -}; +module.exports = require('@backstage/cli/config/eslint-factory')(__dirname); diff --git a/plugins/auth-backend/.eslintrc.js b/plugins/auth-backend/.eslintrc.js index 16a033dbc6..e2a53a6ad2 100644 --- a/plugins/auth-backend/.eslintrc.js +++ b/plugins/auth-backend/.eslintrc.js @@ -1,3 +1 @@ -module.exports = { - extends: [require.resolve('@backstage/cli/config/eslint.backend')], -}; +module.exports = require('@backstage/cli/config/eslint-factory')(__dirname); diff --git a/plugins/auth-node/.eslintrc.js b/plugins/auth-node/.eslintrc.js index 16a033dbc6..e2a53a6ad2 100644 --- a/plugins/auth-node/.eslintrc.js +++ b/plugins/auth-node/.eslintrc.js @@ -1,3 +1 @@ -module.exports = { - extends: [require.resolve('@backstage/cli/config/eslint.backend')], -}; +module.exports = require('@backstage/cli/config/eslint-factory')(__dirname); diff --git a/plugins/azure-devops-backend/.eslintrc.js b/plugins/azure-devops-backend/.eslintrc.js index 16a033dbc6..e2a53a6ad2 100644 --- a/plugins/azure-devops-backend/.eslintrc.js +++ b/plugins/azure-devops-backend/.eslintrc.js @@ -1,3 +1 @@ -module.exports = { - extends: [require.resolve('@backstage/cli/config/eslint.backend')], -}; +module.exports = require('@backstage/cli/config/eslint-factory')(__dirname); diff --git a/plugins/azure-devops-common/.eslintrc.js b/plugins/azure-devops-common/.eslintrc.js index 13573efa9c..e2a53a6ad2 100644 --- a/plugins/azure-devops-common/.eslintrc.js +++ b/plugins/azure-devops-common/.eslintrc.js @@ -1,3 +1 @@ -module.exports = { - extends: [require.resolve('@backstage/cli/config/eslint')], -}; +module.exports = require('@backstage/cli/config/eslint-factory')(__dirname); diff --git a/plugins/azure-devops/.eslintrc.js b/plugins/azure-devops/.eslintrc.js index 13573efa9c..e2a53a6ad2 100644 --- a/plugins/azure-devops/.eslintrc.js +++ b/plugins/azure-devops/.eslintrc.js @@ -1,3 +1 @@ -module.exports = { - extends: [require.resolve('@backstage/cli/config/eslint')], -}; +module.exports = require('@backstage/cli/config/eslint-factory')(__dirname); diff --git a/plugins/badges-backend/.eslintrc.js b/plugins/badges-backend/.eslintrc.js index 16a033dbc6..e2a53a6ad2 100644 --- a/plugins/badges-backend/.eslintrc.js +++ b/plugins/badges-backend/.eslintrc.js @@ -1,3 +1 @@ -module.exports = { - extends: [require.resolve('@backstage/cli/config/eslint.backend')], -}; +module.exports = require('@backstage/cli/config/eslint-factory')(__dirname); diff --git a/plugins/badges/.eslintrc.js b/plugins/badges/.eslintrc.js index 13573efa9c..e2a53a6ad2 100644 --- a/plugins/badges/.eslintrc.js +++ b/plugins/badges/.eslintrc.js @@ -1,3 +1 @@ -module.exports = { - extends: [require.resolve('@backstage/cli/config/eslint')], -}; +module.exports = require('@backstage/cli/config/eslint-factory')(__dirname); diff --git a/plugins/bazaar-backend/.eslintrc.js b/plugins/bazaar-backend/.eslintrc.js index 16a033dbc6..e2a53a6ad2 100644 --- a/plugins/bazaar-backend/.eslintrc.js +++ b/plugins/bazaar-backend/.eslintrc.js @@ -1,3 +1 @@ -module.exports = { - extends: [require.resolve('@backstage/cli/config/eslint.backend')], -}; +module.exports = require('@backstage/cli/config/eslint-factory')(__dirname); diff --git a/plugins/bazaar/.eslintrc.js b/plugins/bazaar/.eslintrc.js index 13573efa9c..e2a53a6ad2 100644 --- a/plugins/bazaar/.eslintrc.js +++ b/plugins/bazaar/.eslintrc.js @@ -1,3 +1 @@ -module.exports = { - extends: [require.resolve('@backstage/cli/config/eslint')], -}; +module.exports = require('@backstage/cli/config/eslint-factory')(__dirname); diff --git a/plugins/bitrise/.eslintrc.js b/plugins/bitrise/.eslintrc.js index 13573efa9c..e2a53a6ad2 100644 --- a/plugins/bitrise/.eslintrc.js +++ b/plugins/bitrise/.eslintrc.js @@ -1,3 +1 @@ -module.exports = { - extends: [require.resolve('@backstage/cli/config/eslint')], -}; +module.exports = require('@backstage/cli/config/eslint-factory')(__dirname); diff --git a/plugins/catalog-backend-module-aws/.eslintrc.js b/plugins/catalog-backend-module-aws/.eslintrc.js index 16a033dbc6..e2a53a6ad2 100644 --- a/plugins/catalog-backend-module-aws/.eslintrc.js +++ b/plugins/catalog-backend-module-aws/.eslintrc.js @@ -1,3 +1 @@ -module.exports = { - extends: [require.resolve('@backstage/cli/config/eslint.backend')], -}; +module.exports = require('@backstage/cli/config/eslint-factory')(__dirname); diff --git a/plugins/catalog-backend-module-ldap/.eslintrc.js b/plugins/catalog-backend-module-ldap/.eslintrc.js index 16a033dbc6..e2a53a6ad2 100644 --- a/plugins/catalog-backend-module-ldap/.eslintrc.js +++ b/plugins/catalog-backend-module-ldap/.eslintrc.js @@ -1,3 +1 @@ -module.exports = { - extends: [require.resolve('@backstage/cli/config/eslint.backend')], -}; +module.exports = require('@backstage/cli/config/eslint-factory')(__dirname); diff --git a/plugins/catalog-backend-module-msgraph/.eslintrc.js b/plugins/catalog-backend-module-msgraph/.eslintrc.js index 16a033dbc6..e2a53a6ad2 100644 --- a/plugins/catalog-backend-module-msgraph/.eslintrc.js +++ b/plugins/catalog-backend-module-msgraph/.eslintrc.js @@ -1,3 +1 @@ -module.exports = { - extends: [require.resolve('@backstage/cli/config/eslint.backend')], -}; +module.exports = require('@backstage/cli/config/eslint-factory')(__dirname); diff --git a/plugins/catalog-backend/.eslintrc.js b/plugins/catalog-backend/.eslintrc.js index 16a033dbc6..e2a53a6ad2 100644 --- a/plugins/catalog-backend/.eslintrc.js +++ b/plugins/catalog-backend/.eslintrc.js @@ -1,3 +1 @@ -module.exports = { - extends: [require.resolve('@backstage/cli/config/eslint.backend')], -}; +module.exports = require('@backstage/cli/config/eslint-factory')(__dirname); diff --git a/plugins/catalog-common/.eslintrc.js b/plugins/catalog-common/.eslintrc.js index 13573efa9c..e2a53a6ad2 100644 --- a/plugins/catalog-common/.eslintrc.js +++ b/plugins/catalog-common/.eslintrc.js @@ -1,3 +1 @@ -module.exports = { - extends: [require.resolve('@backstage/cli/config/eslint')], -}; +module.exports = require('@backstage/cli/config/eslint-factory')(__dirname); diff --git a/plugins/catalog-graph/.eslintrc.js b/plugins/catalog-graph/.eslintrc.js index 13573efa9c..e2a53a6ad2 100644 --- a/plugins/catalog-graph/.eslintrc.js +++ b/plugins/catalog-graph/.eslintrc.js @@ -1,3 +1 @@ -module.exports = { - extends: [require.resolve('@backstage/cli/config/eslint')], -}; +module.exports = require('@backstage/cli/config/eslint-factory')(__dirname); diff --git a/plugins/catalog-graphql/.eslintrc.js b/plugins/catalog-graphql/.eslintrc.js index 16a033dbc6..e2a53a6ad2 100644 --- a/plugins/catalog-graphql/.eslintrc.js +++ b/plugins/catalog-graphql/.eslintrc.js @@ -1,3 +1 @@ -module.exports = { - extends: [require.resolve('@backstage/cli/config/eslint.backend')], -}; +module.exports = require('@backstage/cli/config/eslint-factory')(__dirname); diff --git a/plugins/catalog-import/.eslintrc.js b/plugins/catalog-import/.eslintrc.js index 13573efa9c..e2a53a6ad2 100644 --- a/plugins/catalog-import/.eslintrc.js +++ b/plugins/catalog-import/.eslintrc.js @@ -1,3 +1 @@ -module.exports = { - extends: [require.resolve('@backstage/cli/config/eslint')], -}; +module.exports = require('@backstage/cli/config/eslint-factory')(__dirname); diff --git a/plugins/catalog-react/.eslintrc.js b/plugins/catalog-react/.eslintrc.js index 13573efa9c..e2a53a6ad2 100644 --- a/plugins/catalog-react/.eslintrc.js +++ b/plugins/catalog-react/.eslintrc.js @@ -1,3 +1 @@ -module.exports = { - extends: [require.resolve('@backstage/cli/config/eslint')], -}; +module.exports = require('@backstage/cli/config/eslint-factory')(__dirname); diff --git a/plugins/catalog/.eslintrc.js b/plugins/catalog/.eslintrc.js index 13573efa9c..e2a53a6ad2 100644 --- a/plugins/catalog/.eslintrc.js +++ b/plugins/catalog/.eslintrc.js @@ -1,3 +1 @@ -module.exports = { - extends: [require.resolve('@backstage/cli/config/eslint')], -}; +module.exports = require('@backstage/cli/config/eslint-factory')(__dirname); diff --git a/plugins/cicd-statistics/.eslintrc.js b/plugins/cicd-statistics/.eslintrc.js index 13573efa9c..e2a53a6ad2 100644 --- a/plugins/cicd-statistics/.eslintrc.js +++ b/plugins/cicd-statistics/.eslintrc.js @@ -1,3 +1 @@ -module.exports = { - extends: [require.resolve('@backstage/cli/config/eslint')], -}; +module.exports = require('@backstage/cli/config/eslint-factory')(__dirname); diff --git a/plugins/circleci/.eslintrc.js b/plugins/circleci/.eslintrc.js index 13573efa9c..e2a53a6ad2 100644 --- a/plugins/circleci/.eslintrc.js +++ b/plugins/circleci/.eslintrc.js @@ -1,3 +1 @@ -module.exports = { - extends: [require.resolve('@backstage/cli/config/eslint')], -}; +module.exports = require('@backstage/cli/config/eslint-factory')(__dirname); diff --git a/plugins/cloudbuild/.eslintrc.js b/plugins/cloudbuild/.eslintrc.js index 13573efa9c..e2a53a6ad2 100644 --- a/plugins/cloudbuild/.eslintrc.js +++ b/plugins/cloudbuild/.eslintrc.js @@ -1,3 +1 @@ -module.exports = { - extends: [require.resolve('@backstage/cli/config/eslint')], -}; +module.exports = require('@backstage/cli/config/eslint-factory')(__dirname); diff --git a/plugins/code-climate/.eslintrc.js b/plugins/code-climate/.eslintrc.js index 13573efa9c..e2a53a6ad2 100644 --- a/plugins/code-climate/.eslintrc.js +++ b/plugins/code-climate/.eslintrc.js @@ -1,3 +1 @@ -module.exports = { - extends: [require.resolve('@backstage/cli/config/eslint')], -}; +module.exports = require('@backstage/cli/config/eslint-factory')(__dirname); diff --git a/plugins/code-coverage-backend/.eslintrc.js b/plugins/code-coverage-backend/.eslintrc.js index 16a033dbc6..e2a53a6ad2 100644 --- a/plugins/code-coverage-backend/.eslintrc.js +++ b/plugins/code-coverage-backend/.eslintrc.js @@ -1,3 +1 @@ -module.exports = { - extends: [require.resolve('@backstage/cli/config/eslint.backend')], -}; +module.exports = require('@backstage/cli/config/eslint-factory')(__dirname); diff --git a/plugins/code-coverage/.eslintrc.js b/plugins/code-coverage/.eslintrc.js index 13573efa9c..e2a53a6ad2 100644 --- a/plugins/code-coverage/.eslintrc.js +++ b/plugins/code-coverage/.eslintrc.js @@ -1,3 +1 @@ -module.exports = { - extends: [require.resolve('@backstage/cli/config/eslint')], -}; +module.exports = require('@backstage/cli/config/eslint-factory')(__dirname); diff --git a/plugins/config-schema/.eslintrc.js b/plugins/config-schema/.eslintrc.js index 13573efa9c..e2a53a6ad2 100644 --- a/plugins/config-schema/.eslintrc.js +++ b/plugins/config-schema/.eslintrc.js @@ -1,3 +1 @@ -module.exports = { - extends: [require.resolve('@backstage/cli/config/eslint')], -}; +module.exports = require('@backstage/cli/config/eslint-factory')(__dirname); diff --git a/plugins/cost-insights/.eslintrc.js b/plugins/cost-insights/.eslintrc.js index 13573efa9c..e2a53a6ad2 100644 --- a/plugins/cost-insights/.eslintrc.js +++ b/plugins/cost-insights/.eslintrc.js @@ -1,3 +1 @@ -module.exports = { - extends: [require.resolve('@backstage/cli/config/eslint')], -}; +module.exports = require('@backstage/cli/config/eslint-factory')(__dirname); diff --git a/plugins/explore-react/.eslintrc.js b/plugins/explore-react/.eslintrc.js index 13573efa9c..e2a53a6ad2 100644 --- a/plugins/explore-react/.eslintrc.js +++ b/plugins/explore-react/.eslintrc.js @@ -1,3 +1 @@ -module.exports = { - extends: [require.resolve('@backstage/cli/config/eslint')], -}; +module.exports = require('@backstage/cli/config/eslint-factory')(__dirname); diff --git a/plugins/explore/.eslintrc.js b/plugins/explore/.eslintrc.js index 13573efa9c..e2a53a6ad2 100644 --- a/plugins/explore/.eslintrc.js +++ b/plugins/explore/.eslintrc.js @@ -1,3 +1 @@ -module.exports = { - extends: [require.resolve('@backstage/cli/config/eslint')], -}; +module.exports = require('@backstage/cli/config/eslint-factory')(__dirname); diff --git a/plugins/firehydrant/.eslintrc.js b/plugins/firehydrant/.eslintrc.js index 13573efa9c..e2a53a6ad2 100644 --- a/plugins/firehydrant/.eslintrc.js +++ b/plugins/firehydrant/.eslintrc.js @@ -1,3 +1 @@ -module.exports = { - extends: [require.resolve('@backstage/cli/config/eslint')], -}; +module.exports = require('@backstage/cli/config/eslint-factory')(__dirname); diff --git a/plugins/fossa/.eslintrc.js b/plugins/fossa/.eslintrc.js index 13573efa9c..e2a53a6ad2 100644 --- a/plugins/fossa/.eslintrc.js +++ b/plugins/fossa/.eslintrc.js @@ -1,3 +1 @@ -module.exports = { - extends: [require.resolve('@backstage/cli/config/eslint')], -}; +module.exports = require('@backstage/cli/config/eslint-factory')(__dirname); diff --git a/plugins/gcp-projects/.eslintrc.js b/plugins/gcp-projects/.eslintrc.js index 13573efa9c..e2a53a6ad2 100644 --- a/plugins/gcp-projects/.eslintrc.js +++ b/plugins/gcp-projects/.eslintrc.js @@ -1,3 +1 @@ -module.exports = { - extends: [require.resolve('@backstage/cli/config/eslint')], -}; +module.exports = require('@backstage/cli/config/eslint-factory')(__dirname); diff --git a/plugins/git-release-manager/.eslintrc.js b/plugins/git-release-manager/.eslintrc.js index 13573efa9c..e2a53a6ad2 100644 --- a/plugins/git-release-manager/.eslintrc.js +++ b/plugins/git-release-manager/.eslintrc.js @@ -1,3 +1 @@ -module.exports = { - extends: [require.resolve('@backstage/cli/config/eslint')], -}; +module.exports = require('@backstage/cli/config/eslint-factory')(__dirname); diff --git a/plugins/github-actions/.eslintrc.js b/plugins/github-actions/.eslintrc.js index 13573efa9c..e2a53a6ad2 100644 --- a/plugins/github-actions/.eslintrc.js +++ b/plugins/github-actions/.eslintrc.js @@ -1,3 +1 @@ -module.exports = { - extends: [require.resolve('@backstage/cli/config/eslint')], -}; +module.exports = require('@backstage/cli/config/eslint-factory')(__dirname); diff --git a/plugins/github-deployments/.eslintrc.js b/plugins/github-deployments/.eslintrc.js index 13573efa9c..e2a53a6ad2 100644 --- a/plugins/github-deployments/.eslintrc.js +++ b/plugins/github-deployments/.eslintrc.js @@ -1,3 +1 @@ -module.exports = { - extends: [require.resolve('@backstage/cli/config/eslint')], -}; +module.exports = require('@backstage/cli/config/eslint-factory')(__dirname); diff --git a/plugins/gitops-profiles/.eslintrc.js b/plugins/gitops-profiles/.eslintrc.js index 13573efa9c..e2a53a6ad2 100644 --- a/plugins/gitops-profiles/.eslintrc.js +++ b/plugins/gitops-profiles/.eslintrc.js @@ -1,3 +1 @@ -module.exports = { - extends: [require.resolve('@backstage/cli/config/eslint')], -}; +module.exports = require('@backstage/cli/config/eslint-factory')(__dirname); diff --git a/plugins/gocd/.eslintrc.js b/plugins/gocd/.eslintrc.js index 13573efa9c..e2a53a6ad2 100644 --- a/plugins/gocd/.eslintrc.js +++ b/plugins/gocd/.eslintrc.js @@ -1,3 +1 @@ -module.exports = { - extends: [require.resolve('@backstage/cli/config/eslint')], -}; +module.exports = require('@backstage/cli/config/eslint-factory')(__dirname); diff --git a/plugins/graphiql/.eslintrc.js b/plugins/graphiql/.eslintrc.js index 6a513fbafe..e358722664 100644 --- a/plugins/graphiql/.eslintrc.js +++ b/plugins/graphiql/.eslintrc.js @@ -1,7 +1,5 @@ -module.exports = { - extends: [require.resolve('@backstage/cli/config/eslint')], +module.exports = require('@backstage/cli/config/eslint-factory')(__dirname, { rules: { - // Prefer to use rendered.getBy*, which will throw an error 'jest/expect-expect': 0, }, -}; +}); diff --git a/plugins/graphql-backend/.eslintrc.js b/plugins/graphql-backend/.eslintrc.js index 16a033dbc6..e2a53a6ad2 100644 --- a/plugins/graphql-backend/.eslintrc.js +++ b/plugins/graphql-backend/.eslintrc.js @@ -1,3 +1 @@ -module.exports = { - extends: [require.resolve('@backstage/cli/config/eslint.backend')], -}; +module.exports = require('@backstage/cli/config/eslint-factory')(__dirname); diff --git a/plugins/home/.eslintrc.js b/plugins/home/.eslintrc.js index 13573efa9c..e2a53a6ad2 100644 --- a/plugins/home/.eslintrc.js +++ b/plugins/home/.eslintrc.js @@ -1,3 +1 @@ -module.exports = { - extends: [require.resolve('@backstage/cli/config/eslint')], -}; +module.exports = require('@backstage/cli/config/eslint-factory')(__dirname); diff --git a/plugins/ilert/.eslintrc.js b/plugins/ilert/.eslintrc.js index 4d51616e98..b4ec729b09 100644 --- a/plugins/ilert/.eslintrc.js +++ b/plugins/ilert/.eslintrc.js @@ -1,6 +1,5 @@ -module.exports = { - extends: [require.resolve('@backstage/cli/config/eslint')], +module.exports = require('@backstage/cli/config/eslint-factory')(__dirname, { rules: { quotes: ['error', 'single'], }, -}; +}); diff --git a/plugins/jenkins-backend/.eslintrc.js b/plugins/jenkins-backend/.eslintrc.js index 16a033dbc6..e2a53a6ad2 100644 --- a/plugins/jenkins-backend/.eslintrc.js +++ b/plugins/jenkins-backend/.eslintrc.js @@ -1,3 +1 @@ -module.exports = { - extends: [require.resolve('@backstage/cli/config/eslint.backend')], -}; +module.exports = require('@backstage/cli/config/eslint-factory')(__dirname); diff --git a/plugins/jenkins-common/.eslintrc.js b/plugins/jenkins-common/.eslintrc.js index 13573efa9c..e2a53a6ad2 100644 --- a/plugins/jenkins-common/.eslintrc.js +++ b/plugins/jenkins-common/.eslintrc.js @@ -1,3 +1 @@ -module.exports = { - extends: [require.resolve('@backstage/cli/config/eslint')], -}; +module.exports = require('@backstage/cli/config/eslint-factory')(__dirname); diff --git a/plugins/jenkins/.eslintrc.js b/plugins/jenkins/.eslintrc.js index 13573efa9c..e2a53a6ad2 100644 --- a/plugins/jenkins/.eslintrc.js +++ b/plugins/jenkins/.eslintrc.js @@ -1,3 +1 @@ -module.exports = { - extends: [require.resolve('@backstage/cli/config/eslint')], -}; +module.exports = require('@backstage/cli/config/eslint-factory')(__dirname); diff --git a/plugins/kafka-backend/.eslintrc.js b/plugins/kafka-backend/.eslintrc.js index 16a033dbc6..e2a53a6ad2 100644 --- a/plugins/kafka-backend/.eslintrc.js +++ b/plugins/kafka-backend/.eslintrc.js @@ -1,3 +1 @@ -module.exports = { - extends: [require.resolve('@backstage/cli/config/eslint.backend')], -}; +module.exports = require('@backstage/cli/config/eslint-factory')(__dirname); diff --git a/plugins/kafka/.eslintrc.js b/plugins/kafka/.eslintrc.js index 13573efa9c..e2a53a6ad2 100644 --- a/plugins/kafka/.eslintrc.js +++ b/plugins/kafka/.eslintrc.js @@ -1,3 +1 @@ -module.exports = { - extends: [require.resolve('@backstage/cli/config/eslint')], -}; +module.exports = require('@backstage/cli/config/eslint-factory')(__dirname); diff --git a/plugins/kubernetes-backend/.eslintrc.js b/plugins/kubernetes-backend/.eslintrc.js index 16a033dbc6..e2a53a6ad2 100644 --- a/plugins/kubernetes-backend/.eslintrc.js +++ b/plugins/kubernetes-backend/.eslintrc.js @@ -1,3 +1 @@ -module.exports = { - extends: [require.resolve('@backstage/cli/config/eslint.backend')], -}; +module.exports = require('@backstage/cli/config/eslint-factory')(__dirname); diff --git a/plugins/kubernetes-common/.eslintrc.js b/plugins/kubernetes-common/.eslintrc.js index 16a033dbc6..e2a53a6ad2 100644 --- a/plugins/kubernetes-common/.eslintrc.js +++ b/plugins/kubernetes-common/.eslintrc.js @@ -1,3 +1 @@ -module.exports = { - extends: [require.resolve('@backstage/cli/config/eslint.backend')], -}; +module.exports = require('@backstage/cli/config/eslint-factory')(__dirname); diff --git a/plugins/kubernetes/.eslintrc.js b/plugins/kubernetes/.eslintrc.js index 13573efa9c..e2a53a6ad2 100644 --- a/plugins/kubernetes/.eslintrc.js +++ b/plugins/kubernetes/.eslintrc.js @@ -1,3 +1 @@ -module.exports = { - extends: [require.resolve('@backstage/cli/config/eslint')], -}; +module.exports = require('@backstage/cli/config/eslint-factory')(__dirname); diff --git a/plugins/lighthouse/.eslintrc.js b/plugins/lighthouse/.eslintrc.js index 13573efa9c..e2a53a6ad2 100644 --- a/plugins/lighthouse/.eslintrc.js +++ b/plugins/lighthouse/.eslintrc.js @@ -1,3 +1 @@ -module.exports = { - extends: [require.resolve('@backstage/cli/config/eslint')], -}; +module.exports = require('@backstage/cli/config/eslint-factory')(__dirname); diff --git a/plugins/newrelic-dashboard/.eslintrc.js b/plugins/newrelic-dashboard/.eslintrc.js index 13573efa9c..e2a53a6ad2 100644 --- a/plugins/newrelic-dashboard/.eslintrc.js +++ b/plugins/newrelic-dashboard/.eslintrc.js @@ -1,3 +1 @@ -module.exports = { - extends: [require.resolve('@backstage/cli/config/eslint')], -}; +module.exports = require('@backstage/cli/config/eslint-factory')(__dirname); diff --git a/plugins/newrelic/.eslintrc.js b/plugins/newrelic/.eslintrc.js index 13573efa9c..e2a53a6ad2 100644 --- a/plugins/newrelic/.eslintrc.js +++ b/plugins/newrelic/.eslintrc.js @@ -1,3 +1 @@ -module.exports = { - extends: [require.resolve('@backstage/cli/config/eslint')], -}; +module.exports = require('@backstage/cli/config/eslint-factory')(__dirname); diff --git a/plugins/org/.eslintrc.js b/plugins/org/.eslintrc.js index 13573efa9c..e2a53a6ad2 100644 --- a/plugins/org/.eslintrc.js +++ b/plugins/org/.eslintrc.js @@ -1,3 +1 @@ -module.exports = { - extends: [require.resolve('@backstage/cli/config/eslint')], -}; +module.exports = require('@backstage/cli/config/eslint-factory')(__dirname); diff --git a/plugins/pagerduty/.eslintrc.js b/plugins/pagerduty/.eslintrc.js index 13573efa9c..e2a53a6ad2 100644 --- a/plugins/pagerduty/.eslintrc.js +++ b/plugins/pagerduty/.eslintrc.js @@ -1,3 +1 @@ -module.exports = { - extends: [require.resolve('@backstage/cli/config/eslint')], -}; +module.exports = require('@backstage/cli/config/eslint-factory')(__dirname); diff --git a/plugins/permission-backend/.eslintrc.js b/plugins/permission-backend/.eslintrc.js index 16a033dbc6..e2a53a6ad2 100644 --- a/plugins/permission-backend/.eslintrc.js +++ b/plugins/permission-backend/.eslintrc.js @@ -1,3 +1 @@ -module.exports = { - extends: [require.resolve('@backstage/cli/config/eslint.backend')], -}; +module.exports = require('@backstage/cli/config/eslint-factory')(__dirname); diff --git a/plugins/permission-common/.eslintrc.js b/plugins/permission-common/.eslintrc.js index 16a033dbc6..e2a53a6ad2 100644 --- a/plugins/permission-common/.eslintrc.js +++ b/plugins/permission-common/.eslintrc.js @@ -1,3 +1 @@ -module.exports = { - extends: [require.resolve('@backstage/cli/config/eslint.backend')], -}; +module.exports = require('@backstage/cli/config/eslint-factory')(__dirname); diff --git a/plugins/permission-node/.eslintrc.js b/plugins/permission-node/.eslintrc.js index 16a033dbc6..e2a53a6ad2 100644 --- a/plugins/permission-node/.eslintrc.js +++ b/plugins/permission-node/.eslintrc.js @@ -1,3 +1 @@ -module.exports = { - extends: [require.resolve('@backstage/cli/config/eslint.backend')], -}; +module.exports = require('@backstage/cli/config/eslint-factory')(__dirname); diff --git a/plugins/permission-react/.eslintrc.js b/plugins/permission-react/.eslintrc.js index 13573efa9c..e2a53a6ad2 100644 --- a/plugins/permission-react/.eslintrc.js +++ b/plugins/permission-react/.eslintrc.js @@ -1,3 +1 @@ -module.exports = { - extends: [require.resolve('@backstage/cli/config/eslint')], -}; +module.exports = require('@backstage/cli/config/eslint-factory')(__dirname); diff --git a/plugins/proxy-backend/.eslintrc.js b/plugins/proxy-backend/.eslintrc.js index 16a033dbc6..e2a53a6ad2 100644 --- a/plugins/proxy-backend/.eslintrc.js +++ b/plugins/proxy-backend/.eslintrc.js @@ -1,3 +1 @@ -module.exports = { - extends: [require.resolve('@backstage/cli/config/eslint.backend')], -}; +module.exports = require('@backstage/cli/config/eslint-factory')(__dirname); diff --git a/plugins/rollbar-backend/.eslintrc.js b/plugins/rollbar-backend/.eslintrc.js index 16a033dbc6..e2a53a6ad2 100644 --- a/plugins/rollbar-backend/.eslintrc.js +++ b/plugins/rollbar-backend/.eslintrc.js @@ -1,3 +1 @@ -module.exports = { - extends: [require.resolve('@backstage/cli/config/eslint.backend')], -}; +module.exports = require('@backstage/cli/config/eslint-factory')(__dirname); diff --git a/plugins/rollbar/.eslintrc.js b/plugins/rollbar/.eslintrc.js index 13573efa9c..e2a53a6ad2 100644 --- a/plugins/rollbar/.eslintrc.js +++ b/plugins/rollbar/.eslintrc.js @@ -1,3 +1 @@ -module.exports = { - extends: [require.resolve('@backstage/cli/config/eslint')], -}; +module.exports = require('@backstage/cli/config/eslint-factory')(__dirname); diff --git a/plugins/scaffolder-backend-module-cookiecutter/.eslintrc.js b/plugins/scaffolder-backend-module-cookiecutter/.eslintrc.js index 16a033dbc6..e2a53a6ad2 100644 --- a/plugins/scaffolder-backend-module-cookiecutter/.eslintrc.js +++ b/plugins/scaffolder-backend-module-cookiecutter/.eslintrc.js @@ -1,3 +1 @@ -module.exports = { - extends: [require.resolve('@backstage/cli/config/eslint.backend')], -}; +module.exports = require('@backstage/cli/config/eslint-factory')(__dirname); diff --git a/plugins/scaffolder-backend-module-rails/.eslintrc.js b/plugins/scaffolder-backend-module-rails/.eslintrc.js index 16a033dbc6..e2a53a6ad2 100644 --- a/plugins/scaffolder-backend-module-rails/.eslintrc.js +++ b/plugins/scaffolder-backend-module-rails/.eslintrc.js @@ -1,3 +1 @@ -module.exports = { - extends: [require.resolve('@backstage/cli/config/eslint.backend')], -}; +module.exports = require('@backstage/cli/config/eslint-factory')(__dirname); diff --git a/plugins/scaffolder-backend-module-yeoman/.eslintrc.js b/plugins/scaffolder-backend-module-yeoman/.eslintrc.js index 16a033dbc6..e2a53a6ad2 100644 --- a/plugins/scaffolder-backend-module-yeoman/.eslintrc.js +++ b/plugins/scaffolder-backend-module-yeoman/.eslintrc.js @@ -1,3 +1 @@ -module.exports = { - extends: [require.resolve('@backstage/cli/config/eslint.backend')], -}; +module.exports = require('@backstage/cli/config/eslint-factory')(__dirname); diff --git a/plugins/scaffolder-backend/.eslintrc.js b/plugins/scaffolder-backend/.eslintrc.js index 2632b5e089..d32253d562 100644 --- a/plugins/scaffolder-backend/.eslintrc.js +++ b/plugins/scaffolder-backend/.eslintrc.js @@ -1,16 +1,16 @@ -const parent = require('@backstage/cli/config/eslint.backend'); - -module.exports = { - extends: [require.resolve('@backstage/cli/config/eslint.backend')], +module.exports = require('@backstage/cli/config/eslint-factory')(__dirname, { ignorePatterns: ['sample-templates/'], rules: { - 'no-console': 0, // Permitted in console programs - 'new-cap': ['error', { capIsNew: false }], // Because Express constructs things e.g. like 'const r = express.Router()' - // Usage of path.resolve is extra sensitive in the scaffolder, so forbid it in non-test code + 'no-console': 0, + 'new-cap': [ + 'error', + { + capIsNew: false, + }, + ], 'no-restricted-imports': [ 'error', { - ...parent.rules['no-restricted-imports'][1], paths: [ { name: 'path', @@ -19,23 +19,41 @@ module.exports = { 'Do not use path.resolve, use `resolveSafeChildPath` from `@backstage/backend-common` instead as it prevents security issues', }, ], + patterns: ['**/../../**/*/src/**', '**/../../**/*/src'], }, ], - 'no-restricted-syntax': parent.rules['no-restricted-syntax'].concat([ + 'no-restricted-syntax': [ + 'error', + { + message: + 'Default import from winston is not allowed, import `* as winston` instead.', + selector: + 'ImportDeclaration[source.value="winston"] ImportDefaultSpecifier', + }, + { + message: + "`__dirname` doesn't refer to the same dir in production builds, try `resolvePackagePath()` from `@backstage/backend-common` instead.", + selector: 'Identifier[name="__dirname"]', + }, { message: 'Do not use path.resolve, use `resolveSafeChildPath` from `@backstage/backend-common` instead as it prevents security issues', selector: 'MemberExpression[object.name="path"][property.name="resolve"]', }, - ]), + ], }, overrides: [ { files: ['*.test.*', 'src/setupTests.*', 'dev/**'], rules: { - 'no-restricted-imports': parent.rules['no-restricted-imports'], + 'no-restricted-imports': [ + 2, + { + patterns: ['**/../../**/*/src/**', '**/../../**/*/src'], + }, + ], }, }, ], -}; +}); diff --git a/plugins/scaffolder-common/.eslintrc.js b/plugins/scaffolder-common/.eslintrc.js index 13573efa9c..e2a53a6ad2 100644 --- a/plugins/scaffolder-common/.eslintrc.js +++ b/plugins/scaffolder-common/.eslintrc.js @@ -1,3 +1 @@ -module.exports = { - extends: [require.resolve('@backstage/cli/config/eslint')], -}; +module.exports = require('@backstage/cli/config/eslint-factory')(__dirname); diff --git a/plugins/scaffolder/.eslintrc.js b/plugins/scaffolder/.eslintrc.js index 13573efa9c..e2a53a6ad2 100644 --- a/plugins/scaffolder/.eslintrc.js +++ b/plugins/scaffolder/.eslintrc.js @@ -1,3 +1 @@ -module.exports = { - extends: [require.resolve('@backstage/cli/config/eslint')], -}; +module.exports = require('@backstage/cli/config/eslint-factory')(__dirname); diff --git a/plugins/search-backend-module-elasticsearch/.eslintrc.js b/plugins/search-backend-module-elasticsearch/.eslintrc.js index 16a033dbc6..e2a53a6ad2 100644 --- a/plugins/search-backend-module-elasticsearch/.eslintrc.js +++ b/plugins/search-backend-module-elasticsearch/.eslintrc.js @@ -1,3 +1 @@ -module.exports = { - extends: [require.resolve('@backstage/cli/config/eslint.backend')], -}; +module.exports = require('@backstage/cli/config/eslint-factory')(__dirname); diff --git a/plugins/search-backend-module-pg/.eslintrc.js b/plugins/search-backend-module-pg/.eslintrc.js index 16a033dbc6..e2a53a6ad2 100644 --- a/plugins/search-backend-module-pg/.eslintrc.js +++ b/plugins/search-backend-module-pg/.eslintrc.js @@ -1,3 +1 @@ -module.exports = { - extends: [require.resolve('@backstage/cli/config/eslint.backend')], -}; +module.exports = require('@backstage/cli/config/eslint-factory')(__dirname); diff --git a/plugins/search-backend-node/.eslintrc.js b/plugins/search-backend-node/.eslintrc.js index 16a033dbc6..e2a53a6ad2 100644 --- a/plugins/search-backend-node/.eslintrc.js +++ b/plugins/search-backend-node/.eslintrc.js @@ -1,3 +1 @@ -module.exports = { - extends: [require.resolve('@backstage/cli/config/eslint.backend')], -}; +module.exports = require('@backstage/cli/config/eslint-factory')(__dirname); diff --git a/plugins/search-backend/.eslintrc.js b/plugins/search-backend/.eslintrc.js index 16a033dbc6..e2a53a6ad2 100644 --- a/plugins/search-backend/.eslintrc.js +++ b/plugins/search-backend/.eslintrc.js @@ -1,3 +1 @@ -module.exports = { - extends: [require.resolve('@backstage/cli/config/eslint.backend')], -}; +module.exports = require('@backstage/cli/config/eslint-factory')(__dirname); diff --git a/plugins/search-common/.eslintrc.js b/plugins/search-common/.eslintrc.js index 16a033dbc6..e2a53a6ad2 100644 --- a/plugins/search-common/.eslintrc.js +++ b/plugins/search-common/.eslintrc.js @@ -1,3 +1 @@ -module.exports = { - extends: [require.resolve('@backstage/cli/config/eslint.backend')], -}; +module.exports = require('@backstage/cli/config/eslint-factory')(__dirname); diff --git a/plugins/search/.eslintrc.js b/plugins/search/.eslintrc.js index 13573efa9c..e2a53a6ad2 100644 --- a/plugins/search/.eslintrc.js +++ b/plugins/search/.eslintrc.js @@ -1,3 +1 @@ -module.exports = { - extends: [require.resolve('@backstage/cli/config/eslint')], -}; +module.exports = require('@backstage/cli/config/eslint-factory')(__dirname); diff --git a/plugins/sentry/.eslintrc.js b/plugins/sentry/.eslintrc.js index 13573efa9c..e2a53a6ad2 100644 --- a/plugins/sentry/.eslintrc.js +++ b/plugins/sentry/.eslintrc.js @@ -1,3 +1 @@ -module.exports = { - extends: [require.resolve('@backstage/cli/config/eslint')], -}; +module.exports = require('@backstage/cli/config/eslint-factory')(__dirname); diff --git a/plugins/shortcuts/.eslintrc.js b/plugins/shortcuts/.eslintrc.js index 13573efa9c..e2a53a6ad2 100644 --- a/plugins/shortcuts/.eslintrc.js +++ b/plugins/shortcuts/.eslintrc.js @@ -1,3 +1 @@ -module.exports = { - extends: [require.resolve('@backstage/cli/config/eslint')], -}; +module.exports = require('@backstage/cli/config/eslint-factory')(__dirname); diff --git a/plugins/sonarqube/.eslintrc.js b/plugins/sonarqube/.eslintrc.js index 13573efa9c..e2a53a6ad2 100644 --- a/plugins/sonarqube/.eslintrc.js +++ b/plugins/sonarqube/.eslintrc.js @@ -1,3 +1 @@ -module.exports = { - extends: [require.resolve('@backstage/cli/config/eslint')], -}; +module.exports = require('@backstage/cli/config/eslint-factory')(__dirname); diff --git a/plugins/splunk-on-call/.eslintrc.js b/plugins/splunk-on-call/.eslintrc.js index 13573efa9c..e2a53a6ad2 100644 --- a/plugins/splunk-on-call/.eslintrc.js +++ b/plugins/splunk-on-call/.eslintrc.js @@ -1,3 +1 @@ -module.exports = { - extends: [require.resolve('@backstage/cli/config/eslint')], -}; +module.exports = require('@backstage/cli/config/eslint-factory')(__dirname); diff --git a/plugins/tech-insights-backend-module-jsonfc/.eslintrc.js b/plugins/tech-insights-backend-module-jsonfc/.eslintrc.js index 16a033dbc6..e2a53a6ad2 100644 --- a/plugins/tech-insights-backend-module-jsonfc/.eslintrc.js +++ b/plugins/tech-insights-backend-module-jsonfc/.eslintrc.js @@ -1,3 +1 @@ -module.exports = { - extends: [require.resolve('@backstage/cli/config/eslint.backend')], -}; +module.exports = require('@backstage/cli/config/eslint-factory')(__dirname); diff --git a/plugins/tech-insights-backend/.eslintrc.js b/plugins/tech-insights-backend/.eslintrc.js index a126c438a4..f98046cfe0 100644 --- a/plugins/tech-insights-backend/.eslintrc.js +++ b/plugins/tech-insights-backend/.eslintrc.js @@ -1,5 +1,4 @@ -module.exports = { - extends: [require.resolve('@backstage/cli/config/eslint.backend')], +module.exports = require('@backstage/cli/config/eslint-factory')(__dirname, { rules: { 'jest/expect-expect': [ 'error', @@ -8,4 +7,4 @@ module.exports = { }, ], }, -}; +}); diff --git a/plugins/tech-insights-common/.eslintrc.js b/plugins/tech-insights-common/.eslintrc.js index 16a033dbc6..e2a53a6ad2 100644 --- a/plugins/tech-insights-common/.eslintrc.js +++ b/plugins/tech-insights-common/.eslintrc.js @@ -1,3 +1 @@ -module.exports = { - extends: [require.resolve('@backstage/cli/config/eslint.backend')], -}; +module.exports = require('@backstage/cli/config/eslint-factory')(__dirname); diff --git a/plugins/tech-insights-node/.eslintrc.js b/plugins/tech-insights-node/.eslintrc.js index 16a033dbc6..e2a53a6ad2 100644 --- a/plugins/tech-insights-node/.eslintrc.js +++ b/plugins/tech-insights-node/.eslintrc.js @@ -1,3 +1 @@ -module.exports = { - extends: [require.resolve('@backstage/cli/config/eslint.backend')], -}; +module.exports = require('@backstage/cli/config/eslint-factory')(__dirname); diff --git a/plugins/tech-insights/.eslintrc.js b/plugins/tech-insights/.eslintrc.js index 13573efa9c..e2a53a6ad2 100644 --- a/plugins/tech-insights/.eslintrc.js +++ b/plugins/tech-insights/.eslintrc.js @@ -1,3 +1 @@ -module.exports = { - extends: [require.resolve('@backstage/cli/config/eslint')], -}; +module.exports = require('@backstage/cli/config/eslint-factory')(__dirname); diff --git a/plugins/tech-radar/.eslintrc.js b/plugins/tech-radar/.eslintrc.js index 13573efa9c..e2a53a6ad2 100644 --- a/plugins/tech-radar/.eslintrc.js +++ b/plugins/tech-radar/.eslintrc.js @@ -1,3 +1 @@ -module.exports = { - extends: [require.resolve('@backstage/cli/config/eslint')], -}; +module.exports = require('@backstage/cli/config/eslint-factory')(__dirname); diff --git a/plugins/techdocs-backend/.eslintrc.js b/plugins/techdocs-backend/.eslintrc.js index 595853b48b..d1e1c522da 100644 --- a/plugins/techdocs-backend/.eslintrc.js +++ b/plugins/techdocs-backend/.eslintrc.js @@ -1,4 +1,3 @@ -module.exports = { - extends: [require.resolve('@backstage/cli/config/eslint.backend')], +module.exports = require('@backstage/cli/config/eslint-factory')(__dirname, { ignorePatterns: ['static/**'], -}; +}); diff --git a/plugins/techdocs-node/.eslintrc.js b/plugins/techdocs-node/.eslintrc.js index 16a033dbc6..e2a53a6ad2 100644 --- a/plugins/techdocs-node/.eslintrc.js +++ b/plugins/techdocs-node/.eslintrc.js @@ -1,3 +1 @@ -module.exports = { - extends: [require.resolve('@backstage/cli/config/eslint.backend')], -}; +module.exports = require('@backstage/cli/config/eslint-factory')(__dirname); diff --git a/plugins/techdocs/.eslintrc.js b/plugins/techdocs/.eslintrc.js index 13573efa9c..e2a53a6ad2 100644 --- a/plugins/techdocs/.eslintrc.js +++ b/plugins/techdocs/.eslintrc.js @@ -1,3 +1 @@ -module.exports = { - extends: [require.resolve('@backstage/cli/config/eslint')], -}; +module.exports = require('@backstage/cli/config/eslint-factory')(__dirname); diff --git a/plugins/todo-backend/.eslintrc.js b/plugins/todo-backend/.eslintrc.js index 16a033dbc6..e2a53a6ad2 100644 --- a/plugins/todo-backend/.eslintrc.js +++ b/plugins/todo-backend/.eslintrc.js @@ -1,3 +1 @@ -module.exports = { - extends: [require.resolve('@backstage/cli/config/eslint.backend')], -}; +module.exports = require('@backstage/cli/config/eslint-factory')(__dirname); diff --git a/plugins/todo/.eslintrc.js b/plugins/todo/.eslintrc.js index 13573efa9c..e2a53a6ad2 100644 --- a/plugins/todo/.eslintrc.js +++ b/plugins/todo/.eslintrc.js @@ -1,3 +1 @@ -module.exports = { - extends: [require.resolve('@backstage/cli/config/eslint')], -}; +module.exports = require('@backstage/cli/config/eslint-factory')(__dirname); diff --git a/plugins/user-settings/.eslintrc.js b/plugins/user-settings/.eslintrc.js index 13573efa9c..e2a53a6ad2 100644 --- a/plugins/user-settings/.eslintrc.js +++ b/plugins/user-settings/.eslintrc.js @@ -1,3 +1 @@ -module.exports = { - extends: [require.resolve('@backstage/cli/config/eslint')], -}; +module.exports = require('@backstage/cli/config/eslint-factory')(__dirname); diff --git a/plugins/xcmetrics/.eslintrc.js b/plugins/xcmetrics/.eslintrc.js index 13573efa9c..e2a53a6ad2 100644 --- a/plugins/xcmetrics/.eslintrc.js +++ b/plugins/xcmetrics/.eslintrc.js @@ -1,3 +1 @@ -module.exports = { - extends: [require.resolve('@backstage/cli/config/eslint')], -}; +module.exports = require('@backstage/cli/config/eslint-factory')(__dirname);