From 0985bb63e77e4cf145d96d1367868dacba9a7252 Mon Sep 17 00:00:00 2001
From: Abhay-soni-developer <abhaysoni.developer@gmail.com>
Date: Wed, 11 Oct 2023 15:03:37 +0530
Subject: [PATCH] changes according to feedback

Signed-off-by: Abhay-soni-developer <abhaysoni.developer@gmail.com>
---
 .../jenkins/src/components/JobRunsTable/JobRunsTable.tsx  | 8 +++-----
 plugins/jenkins/src/components/useJobRuns.ts              | 6 ------
 2 files changed, 3 insertions(+), 11 deletions(-)

diff --git a/plugins/jenkins/src/components/JobRunsTable/JobRunsTable.tsx b/plugins/jenkins/src/components/JobRunsTable/JobRunsTable.tsx
index 73f2e33fd5..78b66b98eb 100644
--- a/plugins/jenkins/src/components/JobRunsTable/JobRunsTable.tsx
+++ b/plugins/jenkins/src/components/JobRunsTable/JobRunsTable.tsx
@@ -90,9 +90,9 @@ const generatedColumns: TableColumn[] = [
           <div style={{ width: '98px' }}>
             {row?.url && (
               <Tooltip title="View build">
-                <IconButton href={row.url} target="_blank">
+                <Link component={IconButton} to={row.url}>
                   <VisibilityIcon />
-                </IconButton>
+                </Link>
               </Tooltip>
             )}
           </div>
@@ -109,7 +109,6 @@ type Props = {
   jobRuns?: Job;
   page: number;
   onChangePage: (page: number) => void;
-  total: number;
   pageSize: number;
   onChangePageSize: (pageSize: number) => void;
 };
@@ -121,7 +120,6 @@ export const JobRunsTableView = ({
   jobRuns,
   onChangePage,
   onChangePageSize,
-  total,
 }: Props) => {
   const builds = jobRuns?.builds.slice(
     page * pageSize,
@@ -150,7 +148,7 @@ export const JobRunsTableView = ({
     <Table
       isLoading={loading}
       options={{ paging: true, pageSize, padding: 'dense' }}
-      totalCount={total}
+      totalCount={jobRuns?.builds.length || 0}
       page={page}
       data={builds ?? []}
       onPageChange={onChangePage}
diff --git a/plugins/jenkins/src/components/useJobRuns.ts b/plugins/jenkins/src/components/useJobRuns.ts
index 5b4739ae67..620bd92b84 100644
--- a/plugins/jenkins/src/components/useJobRuns.ts
+++ b/plugins/jenkins/src/components/useJobRuns.ts
@@ -30,7 +30,6 @@ export function useJobRuns(jobFullName: string) {
   const api = useApi(jenkinsApiRef);
   const errorApi = useApi(errorApiRef);
 
-  const [total, setTotal] = useState(0);
   const [page, setPage] = useState(0);
   const [pageSize, setPageSize] = useState(5);
 
@@ -55,17 +54,12 @@ export function useJobRuns(jobFullName: string) {
     }
   }, [api, errorApi, entity]);
 
-  useEffect(() => {
-    if (jobRuns) setTotal(jobRuns.builds.length);
-  }, [jobRuns]);
-
   return [
     {
       page,
       pageSize,
       loading,
       jobRuns,
-      total,
       error,
     },
     {