From 09229c135a1b01772ec1b27f503959fded3aef68 Mon Sep 17 00:00:00 2001 From: Benjamin Janssens Date: Wed, 4 Sep 2024 16:37:51 +0200 Subject: [PATCH] fix: add examples; improve consistency of tests Signed-off-by: Benjamin Janssens --- .../bitbucketCloudPullRequest.examples.test.ts | 12 ++++++------ .../src/actions/bitbucketCloudPullRequest.ts | 3 ++- 2 files changed, 8 insertions(+), 7 deletions(-) diff --git a/plugins/scaffolder-backend-module-bitbucket-cloud/src/actions/bitbucketCloudPullRequest.examples.test.ts b/plugins/scaffolder-backend-module-bitbucket-cloud/src/actions/bitbucketCloudPullRequest.examples.test.ts index 14d33b8dba..6b30efaa0b 100644 --- a/plugins/scaffolder-backend-module-bitbucket-cloud/src/actions/bitbucketCloudPullRequest.examples.test.ts +++ b/plugins/scaffolder-backend-module-bitbucket-cloud/src/actions/bitbucketCloudPullRequest.examples.test.ts @@ -239,7 +239,7 @@ describe('publish:bitbucketCloud:pull-request', () => { 'https://api.bitbucket.org/2.0/repositories/workspace/repo/refs/branches', (req, res, ctx) => { expect(req.headers.get('Authorization')).toBe( - `Basic ${btoa('test-user:test-password')}`, + 'Basic dGVzdC11c2VyOnRlc3QtcGFzc3dvcmQ=', ); return res( ctx.status(200), @@ -252,7 +252,7 @@ describe('publish:bitbucketCloud:pull-request', () => { 'https://api.bitbucket.org/2.0/repositories/workspace/repo/pullrequests', (req, res, ctx) => { expect(req.headers.get('Authorization')).toBe( - `Basic ${btoa('test-user:test-password')}`, + 'Basic dGVzdC11c2VyOnRlc3QtcGFzc3dvcmQ=', ); return res( ctx.status(201), @@ -279,7 +279,7 @@ describe('publish:bitbucketCloud:pull-request', () => { 'https://api.bitbucket.org/2.0/repositories/workspace/repo/refs/branches', (req, res, ctx) => { expect(req.headers.get('Authorization')).toBe( - `Basic ${btoa('test-user:test-password')}`, + 'Basic dGVzdC11c2VyOnRlc3QtcGFzc3dvcmQ=', ); return res( ctx.status(200), @@ -292,7 +292,7 @@ describe('publish:bitbucketCloud:pull-request', () => { 'https://api.bitbucket.org/2.0/repositories/workspace/repo/pullrequests', (req, res, ctx) => { expect(req.headers.get('Authorization')).toBe( - `Basic ${btoa('test-user:test-password')}`, + 'Basic dGVzdC11c2VyOnRlc3QtcGFzc3dvcmQ=', ); return res( ctx.status(201), @@ -319,7 +319,7 @@ describe('publish:bitbucketCloud:pull-request', () => { 'https://api.bitbucket.org/2.0/repositories/workspace/repo/refs/branches', (req, res, ctx) => { expect(req.headers.get('Authorization')).toBe( - `Basic ${btoa('test-user:test-password')}`, + 'Basic dGVzdC11c2VyOnRlc3QtcGFzc3dvcmQ=', ); return res( ctx.status(200), @@ -332,7 +332,7 @@ describe('publish:bitbucketCloud:pull-request', () => { 'https://api.bitbucket.org/2.0/repositories/workspace/repo/pullrequests', (req, res, ctx) => { expect(req.headers.get('Authorization')).toBe( - `Basic ${btoa('test-user:test-password')}`, + 'Basic dGVzdC11c2VyOnRlc3QtcGFzc3dvcmQ=', ); return res( ctx.status(201), diff --git a/plugins/scaffolder-backend-module-bitbucket-cloud/src/actions/bitbucketCloudPullRequest.ts b/plugins/scaffolder-backend-module-bitbucket-cloud/src/actions/bitbucketCloudPullRequest.ts index d3593dc6f5..f0c352bd68 100644 --- a/plugins/scaffolder-backend-module-bitbucket-cloud/src/actions/bitbucketCloudPullRequest.ts +++ b/plugins/scaffolder-backend-module-bitbucket-cloud/src/actions/bitbucketCloudPullRequest.ts @@ -29,6 +29,7 @@ import fetch, { RequestInit, Response } from 'node-fetch'; import { Config } from '@backstage/config'; import fs from 'fs-extra'; import { getAuthorizationHeader } from './helpers'; +import { examples } from './bitbucketCloudPullRequest.examples'; const createPullRequest = async (opts: { workspace: string; @@ -244,7 +245,7 @@ export function createPublishBitbucketCloudPullRequestAction(options: { gitAuthorEmail?: string; }>({ id: 'publish:bitbucketCloud:pull-request', - // examples, + examples, schema: { input: { type: 'object',