From 07fa501761e432effe6148b43cf49ed91f6a23e5 Mon Sep 17 00:00:00 2001 From: Andre Wanlin <67169551+awanlin@users.noreply.github.com> Date: Mon, 12 Sep 2022 15:12:50 -0500 Subject: [PATCH] Minor updates to the Pemissions docs Signed-off-by: Andre Wanlin <67169551+awanlin@users.noreply.github.com> --- docs/permissions/custom-rules.md | 4 +++- docs/permissions/getting-started.md | 5 +---- 2 files changed, 4 insertions(+), 5 deletions(-) diff --git a/docs/permissions/custom-rules.md b/docs/permissions/custom-rules.md index 0ff0bc230c..1408d732d3 100644 --- a/docs/permissions/custom-rules.md +++ b/docs/permissions/custom-rules.md @@ -49,6 +49,8 @@ The api for providing custom rules may differ between plugins, but there should // packages/backend/src/plugins/catalog.ts import { isInSystemRule } from './permission'; +// The CatalogBuilder with the addPermissionRules function is in the alpha path +import { CatalogBuilder } from '@backstage/plugin-catalog-backend/alpha'; ... @@ -56,7 +58,7 @@ export default async function createPlugin( env: PluginEnvironment, ): Promise { const builder = await CatalogBuilder.create(env); - builder.addPermissionRules(isInSystem); + builder.addPermissionRules(isInSystemRule); ... return router; } diff --git a/docs/permissions/getting-started.md b/docs/permissions/getting-started.md index 6daf448cdd..6e6bcd2d03 100644 --- a/docs/permissions/getting-started.md +++ b/docs/permissions/getting-started.md @@ -77,10 +77,7 @@ export default async function createPlugin( logger: env.logger, discovery: env.discovery, policy: new TestPermissionPolicy(), - identity: IdentityClient.create({ - discovery: env.discovery, - issuer: await env.discovery.getExternalBaseUrl('auth'), - }), + identity: env.identity, }); } ```