From 07d4117abbe2fbd515ec4f2460a8885c49569aa6 Mon Sep 17 00:00:00 2001 From: Clare Liguori Date: Fri, 25 Nov 2022 11:37:16 -0800 Subject: [PATCH] Address PR comments Signed-off-by: Clare Liguori --- .changeset/slow-flies-marry.md | 3 +++ plugins/techdocs-node/src/stages/publish/awsS3.test.ts | 4 ++-- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/.changeset/slow-flies-marry.md b/.changeset/slow-flies-marry.md index ea77e16892..dbf461b013 100644 --- a/.changeset/slow-flies-marry.md +++ b/.changeset/slow-flies-marry.md @@ -4,3 +4,6 @@ --- Upgrade to AWS SDK for Javascript v3 + +Techdocs support for AWS S3 now requires defining the AWS region to connect to +If `techdocs.publisher.awsS3.region` is missing from the config, the AWS environment variable `AWS_REGION` will be used. diff --git a/plugins/techdocs-node/src/stages/publish/awsS3.test.ts b/plugins/techdocs-node/src/stages/publish/awsS3.test.ts index de11ca0814..08facf2208 100644 --- a/plugins/techdocs-node/src/stages/publish/awsS3.test.ts +++ b/plugins/techdocs-node/src/stages/publish/awsS3.test.ts @@ -464,8 +464,8 @@ describe('AwsS3Publish', () => { const fails = publisher.fetchTechDocsMetadata(invalidEntityName); await expect(fails).rejects.toMatchObject({ - message: expect.stringMatching( - 'TechDocs metadata fetch failed; caused by Error: The file invalid/triplet/path/techdocs_metadata.json does not exist', + message: expect.stringContaining( + 'The file invalid/triplet/path/techdocs_metadata.json does not exist', ), }); });