From 3beeff1c820273f1ae001238bc9b12fbfc1d1407 Mon Sep 17 00:00:00 2001 From: David Tuite Date: Tue, 6 Jul 2021 12:13:53 +0100 Subject: [PATCH 1/2] Use target=_blank on MissingAnnotation Read More link I would like Backstage to stay open so I can continue to work with it while I read the docs. Signed-off-by: David Tuite --- .../src/components/EmptyState/MissingAnnotationEmptyState.tsx | 2 ++ 1 file changed, 2 insertions(+) diff --git a/packages/core-components/src/components/EmptyState/MissingAnnotationEmptyState.tsx b/packages/core-components/src/components/EmptyState/MissingAnnotationEmptyState.tsx index 39cce709c0..2b2f2b7738 100644 --- a/packages/core-components/src/components/EmptyState/MissingAnnotationEmptyState.tsx +++ b/packages/core-components/src/components/EmptyState/MissingAnnotationEmptyState.tsx @@ -76,6 +76,8 @@ export const MissingAnnotationEmptyState = ({ annotation }: Props) => { variant="contained" color="primary" href="https://backstage.io/docs/features/software-catalog/well-known-annotations" + target="_blank" + rel="noopener noreferrer" > Read more From 10113f47b221ff44c36364700effb60fddecd5bc Mon Sep 17 00:00:00 2001 From: David Tuite Date: Tue, 6 Jul 2021 14:05:49 +0100 Subject: [PATCH 2/2] Use Link from core-components Signed-off-by: David Tuite --- .../components/EmptyState/MissingAnnotationEmptyState.tsx | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/packages/core-components/src/components/EmptyState/MissingAnnotationEmptyState.tsx b/packages/core-components/src/components/EmptyState/MissingAnnotationEmptyState.tsx index 2b2f2b7738..d477494964 100644 --- a/packages/core-components/src/components/EmptyState/MissingAnnotationEmptyState.tsx +++ b/packages/core-components/src/components/EmptyState/MissingAnnotationEmptyState.tsx @@ -17,6 +17,7 @@ import React from 'react'; import { Button, makeStyles, Typography } from '@material-ui/core'; import { BackstageTheme } from '@backstage/theme'; +import { Link } from '../Link'; import { EmptyState } from './EmptyState'; import { CodeSnippet } from '../CodeSnippet'; @@ -73,11 +74,9 @@ export const MissingAnnotationEmptyState = ({ annotation }: Props) => { />