From eb6a71523accc4bb4621cf7f5891490a53ea04ad Mon Sep 17 00:00:00 2001
From: Emile Fokkema <emilefokkema@gmail.com>
Date: Fri, 7 Jun 2024 20:55:00 +0000
Subject: [PATCH 1/4] add failing test

Signed-off-by: Emile Fokkema <emilefokkema@gmail.com>
---
 .../src/components/Select/Select.test.tsx     | 19 +++++++++++++++++++
 1 file changed, 19 insertions(+)

diff --git a/packages/core-components/src/components/Select/Select.test.tsx b/packages/core-components/src/components/Select/Select.test.tsx
index 71159150e4..e5651ca47f 100644
--- a/packages/core-components/src/components/Select/Select.test.tsx
+++ b/packages/core-components/src/components/Select/Select.test.tsx
@@ -55,6 +55,25 @@ describe('<Select />', () => {
     expect(input.textContent).toBe('test 1');
   });
 
+  it('display nothing when placeholder is empty string and items updated to none', () => {
+    const initialValue = 'initial';
+    const initialItems = [{ label: initialValue, value: initialValue }];
+    const { getByTestId, rerender } = render(
+      <Select
+        {...minProps}
+        items={initialItems}
+        selected={initialValue}
+        placeholder=""
+      />,
+    );
+
+    expect(getByTestId('select').textContent).toBe(initialValue);
+
+    rerender(<Select {...minProps} items={[]} selected="" placeholder="" />);
+
+    expect(getByTestId('select').textContent).toBe('');
+  });
+
   it('display the placeholder value when selected props updated to undefined', async () => {
     const { getByTestId, rerender } = render(
       <Select {...minProps} selected="test_1" />,

From eb60b321bbe91d75170bf7436b8bf78b62eb6493 Mon Sep 17 00:00:00 2001
From: Emile Fokkema <emilefokkema@gmail.com>
Date: Fri, 7 Jun 2024 20:56:59 +0000
Subject: [PATCH 2/4] make test pass

Signed-off-by: Emile Fokkema <emilefokkema@gmail.com>
---
 packages/core-components/src/components/Select/Select.tsx | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/packages/core-components/src/components/Select/Select.tsx b/packages/core-components/src/components/Select/Select.tsx
index 924b49f640..00fb4f21b4 100644
--- a/packages/core-components/src/components/Select/Select.tsx
+++ b/packages/core-components/src/components/Select/Select.tsx
@@ -254,7 +254,7 @@ export function SelectComponent(props: SelectProps) {
             getContentAnchorEl: null,
           }}
         >
-          {placeholder && !multiple && (
+          {!!placeholder && !multiple && (
             <MenuItem value={[]}>{placeholder}</MenuItem>
           )}
           {native

From d4ffdbbce3e76ead5ea97ded0b89a08b2f742533 Mon Sep 17 00:00:00 2001
From: Emile Fokkema <emilefokkema@gmail.com>
Date: Fri, 7 Jun 2024 20:57:58 +0000
Subject: [PATCH 3/4] add changeset

Signed-off-by: Emile Fokkema <emilefokkema@gmail.com>
---
 .changeset/eighty-games-wink.md | 5 +++++
 1 file changed, 5 insertions(+)
 create mode 100644 .changeset/eighty-games-wink.md

diff --git a/.changeset/eighty-games-wink.md b/.changeset/eighty-games-wink.md
new file mode 100644
index 0000000000..46df27d16f
--- /dev/null
+++ b/.changeset/eighty-games-wink.md
@@ -0,0 +1,5 @@
+---
+'@backstage/core-components': patch
+---
+
+Fixed bug where <Select> component with empty string as placeholder gave error

From 35f5d6047f81141da7b02a5945c7b0b65447586d Mon Sep 17 00:00:00 2001
From: Ben Lambert <ben@blam.sh>
Date: Tue, 11 Jun 2024 11:56:21 +0200
Subject: [PATCH 4/4] Update eighty-games-wink.md

Signed-off-by: Ben Lambert <ben@blam.sh>
---
 .changeset/eighty-games-wink.md | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/.changeset/eighty-games-wink.md b/.changeset/eighty-games-wink.md
index 46df27d16f..e87dc56b5f 100644
--- a/.changeset/eighty-games-wink.md
+++ b/.changeset/eighty-games-wink.md
@@ -2,4 +2,4 @@
 '@backstage/core-components': patch
 ---
 
-Fixed bug where <Select> component with empty string as placeholder gave error
+Fixed bug where `<Select>` component with empty string as placeholder gave an error