diff --git a/.changeset/orange-experts-approve.md b/.changeset/orange-experts-approve.md new file mode 100644 index 0000000000..13d1b022da --- /dev/null +++ b/.changeset/orange-experts-approve.md @@ -0,0 +1,5 @@ +--- +'@backstage/plugin-catalog-backend': patch +--- + +Adjust entity query construction to ensure sub-queries are always isolated from one another. diff --git a/plugins/catalog-backend/src/service/NextEntitiesCatalog.ts b/plugins/catalog-backend/src/service/NextEntitiesCatalog.ts index 841e57c921..1c615f862a 100644 --- a/plugins/catalog-backend/src/service/NextEntitiesCatalog.ts +++ b/plugins/catalog-backend/src/service/NextEntitiesCatalog.ts @@ -131,29 +131,25 @@ function parseFilter( db: Knex, ): Knex.QueryBuilder { if (isEntitiesSearchFilter(filter)) { - return query.where(function filterFunction() { + return query.andWhere(function filterFunction() { addCondition(this, db, filter); }); } if (isOrEntityFilter(filter)) { - let cumulativeQuery = query; - for (const subFilter of filter.anyOf ?? []) { - cumulativeQuery = cumulativeQuery.orWhere(subQuery => - parseFilter(subFilter, subQuery, db), - ); - } - return cumulativeQuery; + return query.andWhere(function filterFunction() { + for (const subFilter of filter.anyOf ?? []) { + this.orWhere(subQuery => parseFilter(subFilter, subQuery, db)); + } + }); } if (isAndEntityFilter(filter)) { - let cumulativeQuery = query; - for (const subFilter of filter.allOf ?? []) { - cumulativeQuery = cumulativeQuery.andWhere(subQuery => - parseFilter(subFilter, subQuery, db), - ); - } - return cumulativeQuery; + return query.andWhere(function filterFunction() { + for (const subFilter of filter.allOf ?? []) { + this.andWhere(subQuery => parseFilter(subFilter, subQuery, db)); + } + }); } return query;