From 05fc47c52581bc1116efb06bdbd93024fe3b1b72 Mon Sep 17 00:00:00 2001 From: Axel Hecht Date: Thu, 11 Aug 2022 17:40:04 +0200 Subject: [PATCH] [techdocs/cli] Use light theme if it's not dark, to avoid breaking the theme selector on other values in local storage Fixes #12995 Signed-off-by: Axel Hecht --- .changeset/purple-games-think.md | 5 +++++ .../src/components/TechDocsPage/TechDocsPage.tsx | 2 +- 2 files changed, 6 insertions(+), 1 deletion(-) create mode 100644 .changeset/purple-games-think.md diff --git a/.changeset/purple-games-think.md b/.changeset/purple-games-think.md new file mode 100644 index 0000000000..6247f82249 --- /dev/null +++ b/.changeset/purple-games-think.md @@ -0,0 +1,5 @@ +--- +'techdocs-cli-embedded-app': patch +--- + +Theme selector in `npx @techdocs/cli serve` would break if localstorage had a non-light-or-dark value for theme. diff --git a/packages/techdocs-cli-embedded-app/src/components/TechDocsPage/TechDocsPage.tsx b/packages/techdocs-cli-embedded-app/src/components/TechDocsPage/TechDocsPage.tsx index c7328a0487..cc20081198 100644 --- a/packages/techdocs-cli-embedded-app/src/components/TechDocsPage/TechDocsPage.tsx +++ b/packages/techdocs-cli-embedded-app/src/components/TechDocsPage/TechDocsPage.tsx @@ -55,7 +55,7 @@ export const TechDocsThemeToggle = () => { const appThemeApi = useApi(appThemeApiRef); const classes = useStyles(); const [theme, setTheme] = useState( - (appThemeApi.getActiveThemeId() as Themes) || Themes.LIGHT, + appThemeApi.getActiveThemeId() === Themes.DARK ? Themes.DARK : Themes.LIGHT, ); const themes = {