From 053fc56745b5cc4e6209222032934729b06da047 Mon Sep 17 00:00:00 2001
From: Brenda Sukh <brendasukh@gmail.com>
Date: Fri, 13 Nov 2020 10:15:32 -0500
Subject: [PATCH] Move out utility functions for mock data to utils

---
 plugins/cost-insights/src/client.ts         | 39 +++------------------
 plugins/cost-insights/src/utils/mockData.ts | 30 ++++++++++++++++
 2 files changed, 34 insertions(+), 35 deletions(-)

diff --git a/plugins/cost-insights/src/client.ts b/plugins/cost-insights/src/client.ts
index 740a44fcbd..74d4954ea4 100644
--- a/plugins/cost-insights/src/client.ts
+++ b/plugins/cost-insights/src/client.ts
@@ -16,11 +16,9 @@
 /* eslint-disable no-restricted-imports */
 
 import dayjs from 'dayjs';
-import regression, { DataPoint } from 'regression';
 import { CostInsightsApi, ProductInsightsOptions } from '../src/api';
 import {
   Alert,
-  ChangeStatistic,
   Cost,
   DateAggregation,
   DEFAULT_DATE_FORMAT,
@@ -30,24 +28,21 @@ import {
   MetricData,
   Project,
   ProjectGrowthData,
-  Trendline,
   UnlabeledDataflowData,
 } from '../src/types';
 import {
   ProjectGrowthAlert,
   UnlabeledDataflowAlert,
 } from '../src/utils/alerts';
-import {
-  exclusiveEndDateOf,
-  inclusiveStartDateOf,
-} from '../src/utils/duration';
+import { inclusiveStartDateOf } from '../src/utils/duration';
+import { trendlineOf, changeOf } from './utils/mockData';
 
 type IntervalFields = {
   duration: Duration;
   endDate: string;
 };
 
-function parseIntervals(intervals: string): IntervalFields {
+export function parseIntervals(intervals: string): IntervalFields {
   const match = intervals.match(
     /\/(?<duration>P\d+[DM])\/(?<date>\d{4}-\d{2}-\d{2})/,
   );
@@ -66,7 +61,7 @@ function aggregationFor(
   baseline: number,
 ): DateAggregation[] {
   const { duration, endDate } = parseIntervals(intervals);
-  const days = dayjs(exclusiveEndDateOf(duration, endDate)).diff(
+  const days = dayjs(endDate).diff(
     inclusiveStartDateOf(duration, endDate),
     'day',
   );
@@ -86,32 +81,6 @@ function aggregationFor(
   );
 }
 
-function trendlineOf(aggregation: DateAggregation[]): Trendline {
-  const data: ReadonlyArray<DataPoint> = aggregation.map(a => [
-    Date.parse(a.date) / 1000,
-    a.amount,
-  ]);
-  const result = regression.linear(data, { precision: 5 });
-  return {
-    slope: result.equation[0],
-    intercept: result.equation[1],
-  };
-}
-
-function changeOf(aggregation: DateAggregation[]): ChangeStatistic {
-  const half = Math.ceil(aggregation.length / 2);
-  const before = aggregation
-    .slice(0, half)
-    .reduce((sum, a) => sum + a.amount, 0);
-  const after = aggregation
-    .slice(half, aggregation.length)
-    .reduce((sum, a) => sum + a.amount, 0);
-  return {
-    ratio: (after - before) / before,
-    amount: after - before,
-  };
-}
-
 export class ExampleCostInsightsClient implements CostInsightsApi {
   private request(_: any, res: any): Promise<any> {
     return new Promise(resolve => setTimeout(resolve, 0, res));
diff --git a/plugins/cost-insights/src/utils/mockData.ts b/plugins/cost-insights/src/utils/mockData.ts
index ddeb4636b9..f5ad21854a 100644
--- a/plugins/cost-insights/src/utils/mockData.ts
+++ b/plugins/cost-insights/src/utils/mockData.ts
@@ -14,16 +14,20 @@
  * limitations under the License.
  */
 
+import regression, { DataPoint } from 'regression';
 import { Config } from '@backstage/config';
 import { ConfigApi } from '@backstage/core';
 import {
+  ChangeStatistic,
   Duration,
   Entity,
   Product,
   ProductFilters,
   ProjectGrowthData,
+  Trendline,
   UnlabeledDataflowAlertProject,
   UnlabeledDataflowData,
+  DateAggregation,
 } from '../types';
 import {
   DefaultLoadingAction,
@@ -185,3 +189,29 @@ export const MockCostInsightsConfig: Partial<Config> = {
   getConfig: () => MockProductsConfig as Config,
   getOptionalConfig: () => MockMetricsConfig as Config,
 };
+
+export function trendlineOf(aggregation: DateAggregation[]): Trendline {
+  const data: ReadonlyArray<DataPoint> = aggregation.map(a => [
+    Date.parse(a.date) / 1000,
+    a.amount,
+  ]);
+  const result = regression.linear(data, { precision: 5 });
+  return {
+    slope: result.equation[0],
+    intercept: result.equation[1],
+  };
+}
+
+export function changeOf(aggregation: DateAggregation[]): ChangeStatistic {
+  const half = Math.ceil(aggregation.length / 2);
+  const before = aggregation
+    .slice(0, half)
+    .reduce((sum, a) => sum + a.amount, 0);
+  const after = aggregation
+    .slice(half, aggregation.length)
+    .reduce((sum, a) => sum + a.amount, 0);
+  return {
+    ratio: (after - before) / before,
+    amount: after - before,
+  };
+}