From 048038cfa7ecfbb509b2b7a44a398dee1ac5ffcb Mon Sep 17 00:00:00 2001 From: Carlos Esteban Lopez Date: Wed, 22 Nov 2023 15:00:20 -0500 Subject: [PATCH] chore: Address PR comments 2 Signed-off-by: Carlos Esteban Lopez --- plugins/auth-backend-module-vmware-cloud-provider/package.json | 2 +- .../auth-backend-module-vmware-cloud-provider/src/resolvers.ts | 3 +-- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/plugins/auth-backend-module-vmware-cloud-provider/package.json b/plugins/auth-backend-module-vmware-cloud-provider/package.json index 0282029ec1..f48e69154b 100644 --- a/plugins/auth-backend-module-vmware-cloud-provider/package.json +++ b/plugins/auth-backend-module-vmware-cloud-provider/package.json @@ -26,7 +26,6 @@ "@backstage/backend-common": "workspace:^", "@backstage/backend-plugin-api": "workspace:^", "@backstage/catalog-model": "workspace:^", - "@backstage/errors": "workspace:^", "@backstage/plugin-auth-node": "workspace:^", "@types/passport-oauth2": "^1.4.15", "jose": "^4.6.0", @@ -37,6 +36,7 @@ "@backstage/backend-test-utils": "workspace:^", "@backstage/cli": "workspace:^", "@backstage/config": "workspace:^", + "@backstage/errors": "workspace:^", "@backstage/plugin-auth-backend": "workspace:^", "msw": "^2.0.8", "supertest": "^6.3.3" diff --git a/plugins/auth-backend-module-vmware-cloud-provider/src/resolvers.ts b/plugins/auth-backend-module-vmware-cloud-provider/src/resolvers.ts index 4c55b59f17..2b3a78842b 100644 --- a/plugins/auth-backend-module-vmware-cloud-provider/src/resolvers.ts +++ b/plugins/auth-backend-module-vmware-cloud-provider/src/resolvers.ts @@ -14,7 +14,6 @@ * limitations under the License. */ import { stringifyEntityRef } from '@backstage/catalog-model'; -import { NotFoundError } from '@backstage/errors'; import { createSignInResolverFactory, OAuthAuthenticatorResult, @@ -60,7 +59,7 @@ export namespace vmwareCloudSignInResolvers { }, }); } catch (e) { - if (e.name !== NotFoundError.name) { + if (e.name !== 'NotFoundError') { throw e; } return ctx.issueToken({