BackendInitRegistry -> BackendRegistrationPoints

Co-authored-by: Fredrik Adelöw <freben@users.noreply.github.com>
Co-authored-by: Patrik Oldsberg <poldsberg@gmail.com>
Signed-off-by: Johan Haals <johan.haals@gmail.com>
This commit is contained in:
Johan Haals
2022-08-12 14:02:15 +02:00
parent e3d514507a
commit 0452529374
3 changed files with 13 additions and 8 deletions
@@ -14,7 +14,11 @@
* limitations under the License.
*/
import { BackendInitRegistry, BackendFeature, ExtensionPoint } from './types';
import {
BackendRegistrationPoints,
BackendFeature,
ExtensionPoint,
} from './types';
/** @public */
export function createExtensionPoint<T>(options: {
@@ -35,7 +39,7 @@ export function createExtensionPoint<T>(options: {
/** @public */
export interface BackendPluginConfig<TOptions> {
id: string;
register(reg: BackendInitRegistry, options: TOptions): void;
register(reg: BackendRegistrationPoints, options: TOptions): void;
}
/** @public */
@@ -46,7 +50,7 @@ export function createBackendPlugin<TOptions>(
: (options: TOptions) => BackendFeature {
return (options?: TOptions) => ({
id: config.id,
register(register: BackendInitRegistry) {
register(register: BackendRegistrationPoints) {
return config.register(register, options!);
},
});
@@ -57,7 +61,7 @@ export interface BackendModuleConfig<TOptions> {
pluginId: string;
moduleId: string;
register(
reg: Omit<BackendInitRegistry, 'registerExtensionPoint'>,
reg: Omit<BackendRegistrationPoints, 'registerExtensionPoint'>,
options: TOptions,
): void;
}
@@ -70,7 +74,7 @@ export function createBackendModule<TOptions>(
: (options: TOptions) => BackendFeature {
return (options?: TOptions) => ({
id: `${config.pluginId}.${config.moduleId}`,
register(register: BackendInitRegistry) {
register(register: BackendRegistrationPoints) {
// TODO: Hide registerExtensionPoint
return config.register(register, options!);
},
@@ -21,7 +21,7 @@ export {
createExtensionPoint,
} from './factories';
export type {
BackendInitRegistry,
BackendRegistrationPoints,
BackendFeature,
ExtensionPoint,
} from './types';
@@ -36,7 +36,7 @@ export type ExtensionPoint<T> = {
};
/** @public */
export interface BackendInitRegistry {
export interface BackendRegistrationPoints {
registerExtensionPoint<TExtensionPoint>(
ref: ServiceRef<TExtensionPoint>,
impl: TExtensionPoint,
@@ -49,6 +49,7 @@ export interface BackendInitRegistry {
/** @public */
export interface BackendFeature {
// TODO(Rugvip): Try to get rid of the ID at this level, allowing for a feature to register multiple features as a bundle
id: string;
register(reg: BackendInitRegistry): void;
register(reg: BackendRegistrationPoints): void;
}