From 0a9a03c53eee09eca0aa4e821df215d22b371d57 Mon Sep 17 00:00:00 2001 From: Patrik Oldsberg Date: Tue, 6 Feb 2024 12:21:01 +0100 Subject: [PATCH 1/3] config-loader: avoid error on empty config Signed-off-by: Patrik Oldsberg --- .changeset/long-wasps-wait.md | 5 +++++ packages/config-loader/src/schema/compile.ts | 2 +- 2 files changed, 6 insertions(+), 1 deletion(-) create mode 100644 .changeset/long-wasps-wait.md diff --git a/.changeset/long-wasps-wait.md b/.changeset/long-wasps-wait.md new file mode 100644 index 0000000000..f027fb97ce --- /dev/null +++ b/.changeset/long-wasps-wait.md @@ -0,0 +1,5 @@ +--- +'@backstage/config-loader': patch +--- + +Make schema processing gracefully handle an empty config. diff --git a/packages/config-loader/src/schema/compile.ts b/packages/config-loader/src/schema/compile.ts index fd39b0def9..be47b6c906 100644 --- a/packages/config-loader/src/schema/compile.ts +++ b/packages/config-loader/src/schema/compile.ts @@ -190,7 +190,7 @@ export function compileConfigSchemas( }); return configs => { - const config = ConfigReader.fromConfigs(configs).get(); + const config = ConfigReader.fromConfigs(configs).getOptional(); visibilityByDataPath.clear(); deepVisibilityByDataPath.clear(); From 03e55b10207069eb3fdc303849f106552cb358f7 Mon Sep 17 00:00:00 2001 From: Patrik Oldsberg Date: Tue, 6 Feb 2024 12:22:06 +0100 Subject: [PATCH 2/3] create-app: add fallback for app.title config Signed-off-by: Patrik Oldsberg --- .changeset/modern-peaches-clean.md | 5 +++++ packages/app/public/index.html | 2 +- .../templates/default-app/packages/app/public/index.html | 2 +- 3 files changed, 7 insertions(+), 2 deletions(-) create mode 100644 .changeset/modern-peaches-clean.md diff --git a/.changeset/modern-peaches-clean.md b/.changeset/modern-peaches-clean.md new file mode 100644 index 0000000000..13dbb75183 --- /dev/null +++ b/.changeset/modern-peaches-clean.md @@ -0,0 +1,5 @@ +--- +'@backstage/create-app': patch +--- + +Updated the default app index template at `packages/app/public/index.html` to have a fallback value for the `app.title` config. diff --git a/packages/app/public/index.html b/packages/app/public/index.html index a3c3ef19b8..231e96b309 100644 --- a/packages/app/public/index.html +++ b/packages/app/public/index.html @@ -41,7 +41,7 @@ href="<%= publicPath %>/safari-pinned-tab.svg" color="#5bbad5" /> - <%= config.getString('app.title') %> + <%= config.getOptionalString('app.title') ?? 'Backstage' %> <% if (config.has('app.datadogRum')) { %>