From 027056d93811ab1fc811d77cd23a7ecc1ea0ed8f Mon Sep 17 00:00:00 2001
From: Patrik Oldsberg <poldsberg@gmail.com>
Date: Fri, 2 Oct 2020 18:40:28 +0200
Subject: [PATCH] catalog-backend: fix tests for UrlReaderProcessor

---
 .../processors/UrlReaderProcessor.test.ts        | 16 +++++++++++++---
 1 file changed, 13 insertions(+), 3 deletions(-)

diff --git a/plugins/catalog-backend/src/ingestion/processors/UrlReaderProcessor.test.ts b/plugins/catalog-backend/src/ingestion/processors/UrlReaderProcessor.test.ts
index 1ab4cb09b8..e8ee32e765 100644
--- a/plugins/catalog-backend/src/ingestion/processors/UrlReaderProcessor.test.ts
+++ b/plugins/catalog-backend/src/ingestion/processors/UrlReaderProcessor.test.ts
@@ -22,6 +22,8 @@ import {
 } from './types';
 import { setupServer } from 'msw/node';
 import { rest } from 'msw';
+import { getVoidLogger, UrlReaders } from '@backstage/backend-common';
+import { ConfigReader } from '@backstage/config';
 
 describe('UrlReaderProcessor', () => {
   const mockApiOrigin = 'http://localhost:23000';
@@ -32,7 +34,11 @@ describe('UrlReaderProcessor', () => {
   afterAll(() => server.close());
 
   it('should load from url', async () => {
-    const processor = new UrlReaderProcessor();
+    const logger = getVoidLogger();
+    const reader = UrlReaders.default({ logger }).createWithConfig(
+      new ConfigReader({}),
+    );
+    const processor = new UrlReaderProcessor({ reader, logger });
     const spec = {
       type: 'url',
       target: `${mockApiOrigin}/component.yaml`,
@@ -54,7 +60,11 @@ describe('UrlReaderProcessor', () => {
   });
 
   it('should fail load from url with error', async () => {
-    const processor = new UrlReaderProcessor();
+    const logger = getVoidLogger();
+    const reader = UrlReaders.default({ logger }).createWithConfig(
+      new ConfigReader({}),
+    );
+    const processor = new UrlReaderProcessor({ reader, logger });
     const spec = {
       type: 'url',
       target: `${mockApiOrigin}/component-notfound.yaml`,
@@ -74,7 +84,7 @@ describe('UrlReaderProcessor', () => {
     expect(generated.location).toBe(spec);
     expect(generated.error.name).toBe('NotFoundError');
     expect(generated.error.message).toBe(
-      `${mockApiOrigin}/component-notfound.yaml could not be read, 404 Not Found`,
+      `Unable to read url, NotFoundError: could not read ${mockApiOrigin}/component-notfound.yaml, 404 Not Found`,
     );
   });
 });