From 020f0b71db79037b3de6ca2e173b060c2052f971 Mon Sep 17 00:00:00 2001 From: Aramis Sennyey <34432188+sennyeya@users.noreply.github.com> Date: Thu, 1 Feb 2024 12:43:02 -0500 Subject: [PATCH] Apply suggestions from code review Co-authored-by: Vincenzo Scamporlino Signed-off-by: Aramis Sennyey <34432188+sennyeya@users.noreply.github.com> --- .../src/components/UserListPicker/useAllEntitiesCount.ts | 2 +- .../src/components/UserListPicker/useOwnedEntitiesCount.ts | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/plugins/catalog-react/src/components/UserListPicker/useAllEntitiesCount.ts b/plugins/catalog-react/src/components/UserListPicker/useAllEntitiesCount.ts index dae6df55ee..6916d914f7 100644 --- a/plugins/catalog-react/src/components/UserListPicker/useAllEntitiesCount.ts +++ b/plugins/catalog-react/src/components/UserListPicker/useAllEntitiesCount.ts @@ -36,7 +36,7 @@ export function useAllEntitiesCount() { limit: 0, }; - if (Object.keys(catalogFilters).length === 0) { + if (Object.keys(catalogFilters.filter).length === 0) { prevRequest.current = undefined; return prevRequest.current; } diff --git a/plugins/catalog-react/src/components/UserListPicker/useOwnedEntitiesCount.ts b/plugins/catalog-react/src/components/UserListPicker/useOwnedEntitiesCount.ts index 1fc147daf2..833eeb898f 100644 --- a/plugins/catalog-react/src/components/UserListPicker/useOwnedEntitiesCount.ts +++ b/plugins/catalog-react/src/components/UserListPicker/useOwnedEntitiesCount.ts @@ -78,7 +78,7 @@ export function useOwnedEntitiesCount() { useDeepCompareEffect(() => { // context contains no filter, wait - if (Object.keys(catalogFilters).length === 0) { + if (Object.keys(catalogFilters.filter).length === 0) { return; } // ownershipEntityRefs is loading, wait