Merge pull request #3487 from adamdmharvey/fix-visibility

fix(config-loader,cli,example-app): Refactor visibility typo in vars/funcs across multiple packages
This commit is contained in:
Fredrik Adelöw
2020-11-30 14:05:41 +01:00
committed by GitHub
9 changed files with 27 additions and 18 deletions
+6 -6
View File
@@ -25,7 +25,7 @@ export default async (cmd: Command) => {
args: cmd.config,
fromPackage: cmd.package,
});
const visibility = getVisiblityOption(cmd);
const visibility = getVisibilityOption(cmd);
const data = serializeConfigData(appConfigs, schema, visibility);
if (cmd.format === 'json') {
@@ -35,7 +35,7 @@ export default async (cmd: Command) => {
}
};
function getVisiblityOption(cmd: Command): ConfigVisibility {
function getVisibilityOption(cmd: Command): ConfigVisibility {
if (cmd.frontend && cmd.withSecrets) {
throw new Error('Not allowed to combine frontend and secret config');
}
@@ -50,14 +50,14 @@ function getVisiblityOption(cmd: Command): ConfigVisibility {
function serializeConfigData(
appConfigs: AppConfig[],
schema: ConfigSchema,
visiblity: ConfigVisibility,
visibility: ConfigVisibility,
) {
if (visiblity === 'frontend') {
if (visibility === 'frontend') {
const frontendConfigs = schema.process(appConfigs, {
visiblity: ['frontend'],
visibility: ['frontend'],
});
return ConfigReader.fromConfigs(frontendConfigs).get();
} else if (visiblity === 'secret') {
} else if (visibility === 'secret') {
return ConfigReader.fromConfigs(appConfigs).get();
}
+1 -1
View File
@@ -51,7 +51,7 @@ export async function loadCliConfig(options: Options) {
try {
const frontendAppConfigs = schema.process(appConfigs, {
visiblity: ['frontend'],
visibility: ['frontend'],
});
const frontendConfig = ConfigReader.fromConfigs(frontendAppConfigs);