From 018de42a012b3d6cb150cda1c3acbc9c98779267 Mon Sep 17 00:00:00 2001
From: Patrik Oldsberg <poldsberg@gmail.com>
Date: Sun, 7 Sep 2025 13:07:22 +0200
Subject: [PATCH] frontend-app-api: use EXTENSION_FACTORY_ERROR for invalid
 return types

Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
---
 .../src/tree/instantiateAppNodeTree.test.ts   | 19 +++++++++----------
 .../src/tree/instantiateAppNodeTree.ts        |  6 +-----
 2 files changed, 10 insertions(+), 15 deletions(-)

diff --git a/packages/frontend-app-api/src/tree/instantiateAppNodeTree.test.ts b/packages/frontend-app-api/src/tree/instantiateAppNodeTree.test.ts
index 4f1589d3a3..8f892afd56 100644
--- a/packages/frontend-app-api/src/tree/instantiateAppNodeTree.test.ts
+++ b/packages/frontend-app-api/src/tree/instantiateAppNodeTree.test.ts
@@ -1121,8 +1121,9 @@ describe('instantiateAppNodeTree', () => {
           ),
         ).toEqual([
           {
-            code: 'EXTENSION_INVALID',
-            message: 'extension factory did not provide an iterable object',
+            code: 'EXTENSION_FACTORY_ERROR',
+            message:
+              "Failed to instantiate extension 'test', extension factory did not provide an iterable object",
             context: { node: expect.anything() },
           },
         ]);
@@ -1138,7 +1139,6 @@ describe('instantiateAppNodeTree', () => {
           ),
         ).toEqual([
           {
-            // TODO: This should probably be EXTENSION_INVALID
             code: 'EXTENSION_FACTORY_ERROR',
             message:
               "Failed to instantiate extension 'test', extension factory override did not provide an iterable object",
@@ -1157,7 +1157,6 @@ describe('instantiateAppNodeTree', () => {
           ),
         ).toEqual([
           {
-            // TODO: This should probably be EXTENSION_INVALID
             code: 'EXTENSION_FACTORY_ERROR',
             message:
               "Failed to instantiate extension 'test', extension factory middleware did not provide an iterable object",
@@ -1175,8 +1174,9 @@ describe('instantiateAppNodeTree', () => {
           ),
         ).toEqual([
           {
-            code: 'EXTENSION_INVALID',
-            message: 'extension factory did not provide an iterable object',
+            code: 'EXTENSION_FACTORY_ERROR',
+            message:
+              "Failed to instantiate extension 'test:test', extension factory did not provide an iterable object",
             context: { node: expect.anything() },
           },
         ]);
@@ -1194,8 +1194,9 @@ describe('instantiateAppNodeTree', () => {
           ),
         ).toEqual([
           {
-            code: 'EXTENSION_INVALID',
-            message: 'extension factory did not provide an iterable object',
+            code: 'EXTENSION_FACTORY_ERROR',
+            message:
+              "Failed to instantiate extension 'test:test', extension factory did not provide an iterable object",
             context: { node: expect.anything() },
           },
         ]);
@@ -1214,7 +1215,6 @@ describe('instantiateAppNodeTree', () => {
           ),
         ).toEqual([
           {
-            // TODO: This should probably be EXTENSION_INVALID
             code: 'EXTENSION_FACTORY_ERROR',
             message:
               "Failed to instantiate extension 'test:test', extension factory did not provide an iterable object",
@@ -1236,7 +1236,6 @@ describe('instantiateAppNodeTree', () => {
           ),
         ).toEqual([
           {
-            // TODO: This should probably be EXTENSION_INVALID
             code: 'EXTENSION_FACTORY_ERROR',
             message:
               "Failed to instantiate extension 'test:test', original blueprint factory did not provide an iterable object",
diff --git a/packages/frontend-app-api/src/tree/instantiateAppNodeTree.ts b/packages/frontend-app-api/src/tree/instantiateAppNodeTree.ts
index 62bf64ebc7..f8e18cdcbd 100644
--- a/packages/frontend-app-api/src/tree/instantiateAppNodeTree.ts
+++ b/packages/frontend-app-api/src/tree/instantiateAppNodeTree.ts
@@ -392,11 +392,7 @@ export function createAppNodeInstance(options: {
         typeof outputDataValues !== 'object' ||
         !outputDataValues?.[Symbol.iterator]
       ) {
-        collector.report({
-          code: 'EXTENSION_INVALID',
-          message: 'extension factory did not provide an iterable object',
-        });
-        throw INSTANTIATION_FAILED;
+        throw new Error('extension factory did not provide an iterable object');
       }
 
       const outputDataMap = new Map<string, unknown>();