just a few more circular dependencies

Signed-off-by: Fredrik Adelöw <freben@gmail.com>

.changeset/nice-ties-film.md

@@ -0,0 +1,9 @@
+---
+'@backstage/frontend-plugin-api': patch
+'@backstage/frontend-app-api': patch
+'@backstage/core-plugin-api': patch
+'@backstage/plugin-catalog-node': patch
+'@backstage/plugin-auth-node': patch
+---
+
+Internal tweak to avoid circular dependencies

packages/core-plugin-api/src/apis/definitions/TranslationApi.ts

@@ -16,7 +16,7 @@
 
 import { ApiRef, createApiRef } from '@backstage/core-plugin-api';
 import { Expand, ExpandRecursive, Observable } from '@backstage/types';
-import { TranslationRef } from '../../translation';
+import { TranslationRef } from '../../translation/TranslationRef';
 import { JSX } from 'react';
 
 /**

packages/frontend-app-api/src/routing/collectRouteIds.ts

@@ -29,7 +29,7 @@ import { toInternalExternalRouteRef } from '../../../frontend-plugin-api/src/rou
 // eslint-disable-next-line @backstage/no-relative-monorepo-imports
 import { toInternalSubRouteRef } from '../../../frontend-plugin-api/src/routing/SubRouteRef';
 import { OpaqueFrontendPlugin } from '@internal/frontend';
-import { FrontendFeature } from '../wiring';
+import { FrontendFeature } from '../wiring/types';
 
 /** @internal */
 export interface RouteRefsById {

packages/frontend-plugin-api/report.api.md

@@ -8,6 +8,7 @@ import { alertApiRef } from '@backstage/core-plugin-api';
 import { AlertMessage } from '@backstage/core-plugin-api';
 import { AnyApiFactory } from '@backstage/core-plugin-api';
 import { AnyApiRef } from '@backstage/core-plugin-api';
+import { AnyRouteRefParams as AnyRouteRefParams_2 } from '@backstage/frontend-plugin-api';
 import { ApiFactory } from '@backstage/core-plugin-api';
 import { ApiHolder } from '@backstage/core-plugin-api';
 import { ApiRef } from '@backstage/core-plugin-api';
@@ -392,7 +393,7 @@ export const coreExtensionData: {
   >;
   routePath: ConfigurableExtensionDataRef<string, 'core.routing.path', {}>;
   routeRef: ConfigurableExtensionDataRef<
-    RouteRef<AnyRouteRefParams>,
+    RouteRef<AnyRouteRefParams_2>,
     'core.routing.ref',
     {}
   >;

packages/frontend-plugin-api/src/wiring/coreExtensionData.ts

@@ -15,7 +15,7 @@
  */
 
 import { JSX } from 'react';
-import { RouteRef } from '../routing';
+import { RouteRef } from '../routing/RouteRef';
 import { createExtensionDataRef } from './createExtensionDataRef';
 
 /** @public */

plugins/auth-node/report.api.md

@@ -3,8 +3,6 @@
 > Do not edit this file. It is a report generated by [API Extractor](https://api-extractor.com/).
 
 ```ts
-import { BackstageIdentityResponse as BackstageIdentityResponse_2 } from '@backstage/plugin-auth-node';
-import { BackstageSignInResult as BackstageSignInResult_2 } from '@backstage/plugin-auth-node';
 import { Config } from '@backstage/config';
 import { DiscoveryService } from '@backstage/backend-plugin-api';
 import { Entity } from '@backstage/catalog-model';
@@ -575,8 +573,8 @@ export type PassportProfile = Profile & {
 
 // @public
 export function prepareBackstageIdentityResponse(
-  result: BackstageSignInResult_2,
-): BackstageIdentityResponse_2;
+  result: BackstageSignInResult,
+): BackstageIdentityResponse;
 
 // @public
 export type ProfileInfo = {

plugins/auth-node/src/identity/prepareBackstageIdentityResponse.ts

@@ -15,10 +15,7 @@
  */
 
 import { InputError } from '@backstage/errors';
-import {
-  BackstageIdentityResponse,
-  BackstageSignInResult,
-} from '@backstage/plugin-auth-node';
+import { BackstageIdentityResponse, BackstageSignInResult } from '../types';
 
 function parseJwtPayload(token: string) {
   const [_header, payload, _signature] = token.split('.');

plugins/catalog-node/src/api/provider.ts

@@ -14,7 +14,7 @@
  * limitations under the License.
  */
 
-import { DeferredEntity } from '../processing';
+import { DeferredEntity } from '../processing/types';
 
 /**
  * A 'full' mutation replaces all existing entities created by this entity provider with new ones.

plugins/catalog-node/src/processing/types.ts

@@ -21,7 +21,7 @@ import {
   AnalyzeLocationResponse,
 } from '@backstage/plugin-catalog-common';
 import { JsonValue } from '@backstage/types';
-import { CatalogProcessorEmit } from '../api';
+import { CatalogProcessorEmit } from '../api/processor';
 import { BackstageCredentials } from '@backstage/backend-plugin-api';
 
 /**