diff --git a/.changeset/strange-crabs-confess.md b/.changeset/strange-crabs-confess.md new file mode 100644 index 0000000000..25cb7bbeac --- /dev/null +++ b/.changeset/strange-crabs-confess.md @@ -0,0 +1,5 @@ +--- +'@backstage/plugin-scaffolder-backend': patch +--- + +Add missing res.end() in scaffolder backend EventStream usage diff --git a/plugins/scaffolder-backend/src/service/router.ts b/plugins/scaffolder-backend/src/service/router.ts index b682ebdf25..c7d9af8e64 100644 --- a/plugins/scaffolder-backend/src/service/router.ts +++ b/plugins/scaffolder-backend/src/service/router.ts @@ -311,6 +311,7 @@ export async function createRouter( logger.error( `Received error from event stream when observing taskId '${taskId}', ${error}`, ); + res.end(); }, next: ({ events }) => { let shouldUnsubscribe = false; @@ -324,7 +325,10 @@ export async function createRouter( } // res.flush() is only available with the compression middleware res.flush?.(); - if (shouldUnsubscribe) subscription.unsubscribe(); + if (shouldUnsubscribe) { + subscription.unsubscribe(); + res.end(); + } }, });