From c14affbb4d17c125de60a52e037cda9ce8211bed Mon Sep 17 00:00:00 2001 From: Andrew Thauer Date: Wed, 10 Mar 2021 20:55:35 -0500 Subject: [PATCH] fix(core): ensure link component works with mailto Signed-off-by: Andrew Thauer --- packages/core/src/components/Link/Link.test.tsx | 3 +-- packages/core/src/components/Link/Link.tsx | 2 +- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/packages/core/src/components/Link/Link.test.tsx b/packages/core/src/components/Link/Link.test.tsx index 4efd005a9e..46504e9adc 100644 --- a/packages/core/src/components/Link/Link.test.tsx +++ b/packages/core/src/components/Link/Link.test.tsx @@ -48,7 +48,7 @@ describe('', () => { [true, 'https://some-host/path#fragment'], [true, 'https://some-host/path?param1=value'], [true, 'slack://'], - [true, 'mailto://'], + [true, 'mailto:foo@example.org'], [true, 'ms-help://'], [true, 'ms.help://'], [true, 'ms+help://'], @@ -56,7 +56,6 @@ describe('', () => { [false, '123://'], [false, 'abc&xzy://'], [false, 'http'], - [false, 'https:/a'], [false, 'path/to'], [false, 'path/to/something#fragment'], [false, 'path/to/something?param1=value'], diff --git a/packages/core/src/components/Link/Link.tsx b/packages/core/src/components/Link/Link.tsx index 786d36fe44..31800ddaf1 100644 --- a/packages/core/src/components/Link/Link.tsx +++ b/packages/core/src/components/Link/Link.tsx @@ -24,7 +24,7 @@ import { LinkProps as RouterLinkProps, } from 'react-router-dom'; -export const isExternalUri = (uri: string) => /^([a-z+.-]+):\/\//.test(uri); +export const isExternalUri = (uri: string) => /^([a-z+.-]+):/.test(uri); export type LinkProps = MaterialLinkProps & RouterLinkProps & {