From 00bf7c7e4203c2e20a5f76f909f094dcf2a43d15 Mon Sep 17 00:00:00 2001 From: Johan Persson Date: Tue, 3 Mar 2026 12:49:32 +0100 Subject: [PATCH] fix(ui): remove unused style prop from ButtonOwnProps The style prop was defined in ButtonOwnProps but never destructured or applied in the component, causing it to be silently dropped. Removing it lets style flow through to the underlying RAC Button via restProps instead. Signed-off-by: Johan Persson --- packages/ui/src/components/Button/definition.ts | 1 - packages/ui/src/components/Button/types.ts | 5 ++--- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/packages/ui/src/components/Button/definition.ts b/packages/ui/src/components/Button/definition.ts index d15ceabd77..21d3c7017b 100644 --- a/packages/ui/src/components/Button/definition.ts +++ b/packages/ui/src/components/Button/definition.ts @@ -39,6 +39,5 @@ export const ButtonDefinition = defineComponent()({ iconEnd: {}, children: {}, className: {}, - style: {}, }, }); diff --git a/packages/ui/src/components/Button/types.ts b/packages/ui/src/components/Button/types.ts index a18d9e9164..2bf36d808e 100644 --- a/packages/ui/src/components/Button/types.ts +++ b/packages/ui/src/components/Button/types.ts @@ -14,7 +14,7 @@ * limitations under the License. */ -import type { ReactElement, ReactNode, CSSProperties } from 'react'; +import type { ReactElement, ReactNode } from 'react'; import type { ButtonProps as RAButtonProps } from 'react-aria-components'; import type { Responsive } from '../../types'; @@ -28,7 +28,6 @@ export type ButtonOwnProps = { loading?: boolean; children?: ReactNode; className?: string; - style?: CSSProperties; }; /** @@ -37,5 +36,5 @@ export type ButtonOwnProps = { * @public */ export interface ButtonProps - extends Omit, + extends Omit, ButtonOwnProps {}