From 00448f02e68a5a12562bce23fb285b6ad2f60bbd Mon Sep 17 00:00:00 2001
From: Mike Lewis <mtlewis@users.noreply.github.com>
Date: Thu, 11 Nov 2021 13:28:25 +0000
Subject: [PATCH] authz: fix PermissionCondition type parameter

The type parameter for PermissionCondition refers to the type of the
condition params, not the type of the leaf entries in a
PermissionCriteria object.

It should be safe to always set this type parameter to `unknown[]` in
this case. Each PermissionCondition is will have different parameters,
therefore we just need to enforce that the params is always an array of
unknown.

Signed-off-by: Mike Lewis <mtlewis@users.noreply.github.com>
---
 packages/permission-common/api-report.md    | 2 +-
 packages/permission-common/src/types/api.ts | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/packages/permission-common/api-report.md b/packages/permission-common/api-report.md
index 445125a0c7..c859b71465 100644
--- a/packages/permission-common/api-report.md
+++ b/packages/permission-common/api-report.md
@@ -86,5 +86,5 @@ export type PermissionCriteria<TQuery> =
   | {
       not: PermissionCriteria<TQuery>;
     }
-  | PermissionCondition<TQuery>;
+  | PermissionCondition<unknown[]>;
 ```
diff --git a/packages/permission-common/src/types/api.ts b/packages/permission-common/src/types/api.ts
index a1ba61ba66..be6267775a 100644
--- a/packages/permission-common/src/types/api.ts
+++ b/packages/permission-common/src/types/api.ts
@@ -67,7 +67,7 @@ export type PermissionCriteria<TQuery> =
   | { allOf: PermissionCriteria<TQuery>[] }
   | { anyOf: PermissionCriteria<TQuery>[] }
   | { not: PermissionCriteria<TQuery> }
-  | PermissionCondition<TQuery>;
+  | PermissionCondition<unknown[]>;
 
 /**
  * An authorization response from {@link PermissionClient#authorize}.